Simplify in-context discussion toggles [BD-38] - #339
Conversation
|
Thanks for the pull request, @tecoholic! When this pull request is ready, tag your edX technical lead. |
Codecov ReportBase: 73.89% // Head: 73.95% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #339 +/- ##
==========================================
+ Coverage 73.89% 73.95% +0.06%
==========================================
Files 105 105
Lines 1965 1962 -3
Branches 475 472 -3
==========================================
- Hits 1452 1451 -1
+ Misses 485 484 -1
+ Partials 28 27 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@tecoholic Thank you for the contribution, is this ready for our review? |
|
@natabene Yes. This is ready for review. |
xitij2000
left a comment
There was a problem hiding this comment.
👍 Looks good!
- I tested this: tested on devstack
- I read through the code
c4b9e8f to
085d6ca
Compare
|
@xitij2000 Does this have any related Jira ticket? |
|
@asadazam93 No, you will need to create one if you need it. |
|
@tecoholic 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
…e-react Revert "chore: update react to 17, etc. TNL-10715"
Description
Implements the following changes:
Testing instructions
localhost:2001providervalue toopenedxin http://localhost:18000/admin/discussions/discussionsconfiguration/ for the demo course