feat: string displayNumber added to courses list (#3141) Backport - #3147
Conversation
|
Thanks for the pull request, @diana-villalvazo-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
| displayName: string; | ||
| lmsLink: string | null; | ||
| number: string; | ||
| displayNumber?: string | null; |
There was a problem hiding this comment.
in the ULMO version I had to add this change, because this component is a little bit different comparing to master and verawood
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/ulmo #3147 +/- ##
===============================================
Coverage ? 94.81%
===============================================
Files ? 1230
Lines ? 27574
Branches ? 6229
===============================================
Hits ? 26145
Misses ? 1371
Partials ? 58 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jacobo-dominguez-wgu
left a comment
There was a problem hiding this comment.
LGTM! tested on my local and works well.
Description
Backport of #3141
this is part of this PR
openedx/openedx-platform#38851
now Authoring shows correctly the string display number if exists.
Testing instructions
add "course number display string" to a course in advance settings

this will show the course number string in courses list in authoring home
if there's no Course number display string it will show the course number

Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypesanddefaultPropsin any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../in import paths. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'