Skip to content

feat: string displayNumber added to courses list (#3141) Backport - #3147

Merged
bradenmacdonald merged 2 commits into
openedx:release/ulmofrom
WGU-Open-edX:backport/displayNumber
Jul 21, 2026
Merged

feat: string displayNumber added to courses list (#3141) Backport#3147
bradenmacdonald merged 2 commits into
openedx:release/ulmofrom
WGU-Open-edX:backport/displayNumber

Conversation

@diana-villalvazo-wgu

Copy link
Copy Markdown
Contributor

Description

Backport of #3141
this is part of this PR
openedx/openedx-platform#38851

now Authoring shows correctly the string display number if exists.

Testing instructions

add "course number display string" to a course in advance settings
this will show the course number string in courses list in authoring home
Screenshot 2026-07-16 at 12 00 43 p m

if there's no Course number display string it will show the course number
Screenshot 2026-07-16 at 12 01 17 p m

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Avoid propTypes and defaultProps in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Avoid using ../ in import paths. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Jul 21, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @diana-villalvazo-wgu!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Jul 21, 2026
@jesusbalderramawgu
jesusbalderramawgu requested review from a team and bradenmacdonald July 21, 2026 14:02
@mphilbrick211 mphilbrick211 added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label Jul 21, 2026
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Jul 21, 2026
displayName: string;
lmsLink: string | null;
number: string;
displayNumber?: string | null;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the ULMO version I had to add this change, because this component is a little bit different comparing to master and verawood

@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release/ulmo@849d1e5). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             release/ulmo    #3147   +/-   ##
===============================================
  Coverage                ?   94.81%           
===============================================
  Files                   ?     1230           
  Lines                   ?    27574           
  Branches                ?     6229           
===============================================
  Hits                    ?    26145           
  Misses                  ?     1371           
  Partials                ?       58           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jacobo-dominguez-wgu jacobo-dominguez-wgu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! tested on my local and works well.

@bradenmacdonald
bradenmacdonald merged commit a05f4eb into openedx:release/ulmo Jul 21, 2026
7 checks passed
@github-project-automation github-project-automation Bot moved this from Ready for Review to Done in Contributions Jul 21, 2026
@diana-villalvazo-wgu
diana-villalvazo-wgu deleted the backport/displayNumber branch July 21, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants