Skip to content

Moving code coverage from codecov package to CI - #311

Merged
mamankhan99 merged 4 commits into
masterfrom
maman/codecov-update
Jul 28, 2022
Merged

Moving code coverage from codecov package to CI#311
mamankhan99 merged 4 commits into
masterfrom
maman/codecov-update

Conversation

@mamankhan99

Copy link
Copy Markdown
Contributor

Codecov NodeJS Uploader package is depreciated since version 3.8.3

This PR move the coverage to CI according to the new guidelines and depreciation plan of codecov

@codecov

codecov Bot commented Jun 15, 2022

Copy link
Copy Markdown

Codecov Report

Merging #311 (7d2881a) into master (21c36a4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #311   +/-   ##
=======================================
  Coverage   73.89%   73.89%           
=======================================
  Files         105      105           
  Lines        1965     1965           
  Branches      475      475           
=======================================
  Hits         1452     1452           
  Misses        485      485           
  Partials       28       28           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21c36a4...7d2881a. Read the comment docs.

@mamankhan99 mamankhan99 self-assigned this Jun 16, 2022
@mamankhan99
mamankhan99 requested a review from a team June 16, 2022 11:55

@arbrandes arbrandes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in principle: I'm just curious about the large package-lock diff. Did you regenerate it from scratch?

@mamankhan99

Copy link
Copy Markdown
Contributor Author

Yes, it is regenerated.

@mamankhan99
mamankhan99 requested a review from arbrandes June 20, 2022 05:12
@jmbowman

Copy link
Copy Markdown

@mamankhan99 Looks like this will need a rebase before merging. I'll ping the owning team for review once that's done.

@mamankhan99

Copy link
Copy Markdown
Contributor Author

@mamankhan99 Looks like this will need a rebase before merging. I'll ping the owning team for review once that's done.

@jmbowman pr is rebased, and ready for review.

@connorhaugh connorhaugh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable googling how CI codecov works.

@mamankhan99

mamankhan99 commented Jul 7, 2022

Copy link
Copy Markdown
Contributor Author

@jmbowman should I merge this PR or do we need to tag the relevant person?

@jmbowman

jmbowman commented Jul 7, 2022

Copy link
Copy Markdown

Should be good to merge, Connor is the owning squad representative.

@jmbowman jmbowman added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Jul 25, 2022
@mamankhan99 mamankhan99 removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Jul 28, 2022
@mamankhan99
mamankhan99 merged commit fcb9e91 into master Jul 28, 2022
@mamankhan99
mamankhan99 deleted the maman/codecov-update branch July 28, 2022 11:31
bradenmacdonald pushed a commit to open-craft/frontend-app-authoring that referenced this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants