Moving code coverage from codecov package to CI - #311
Conversation
Codecov Report
@@ Coverage Diff @@
## master #311 +/- ##
=======================================
Coverage 73.89% 73.89%
=======================================
Files 105 105
Lines 1965 1965
Branches 475 475
=======================================
Hits 1452 1452
Misses 485 485
Partials 28 28 Continue to review full report at Codecov.
|
arbrandes
left a comment
There was a problem hiding this comment.
Looks good in principle: I'm just curious about the large package-lock diff. Did you regenerate it from scratch?
|
Yes, it is regenerated. |
|
@mamankhan99 Looks like this will need a rebase before merging. I'll ping the owning team for review once that's done. |
@jmbowman pr is rebased, and ready for review. |
connorhaugh
left a comment
There was a problem hiding this comment.
Looks reasonable googling how CI codecov works.
|
@jmbowman should I merge this PR or do we need to tag the relevant person? |
|
Should be good to merge, Connor is the owning squad representative. |
Codecov NodeJS Uploader package is depreciated since version 3.8.3
This PR move the coverage to CI according to the new guidelines and depreciation plan of codecov