refactor: minor typing improvements - #2395
Conversation
|
Thanks for the pull request, @bradenmacdonald! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2395 +/- ##
=======================================
Coverage 94.54% 94.54%
=======================================
Files 1174 1174
Lines 25322 25322
Branches 5543 5543
=======================================
Hits 23940 23940
Misses 1313 1313
Partials 69 69 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
This makes some minor typing improvements in our test code, seen while reviewing #2324
Specifically instead of just
{...} as XBlockwhich is an unsafe cast, we can use{...} satisfies Partial<XBlock> as XBlockwhich is a safer cast that lets you omit fields but requires that the fields you do include have the correct type.Supporting information
Private ref FAL-4228
Testing instructions
No runtime changes so no manual testing needed; make sure tests are green.