[Teak] style: Fixing nits about sync units [FC-0097] - #2320
Conversation
|
Thanks for the pull request, @ChrisChV! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
457b995 to
f4a92f7
Compare
* Stay visible the sync icon in the course outline * Update the message in the sync unit modal * Add warning banner about units in the libraries sync page
f4a92f7 to
8dfc215
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/teak #2320 +/- ##
===============================================
Coverage ? 93.90%
===============================================
Files ? 1149
Lines ? 24099
Branches ? 5093
===============================================
Hits ? 22629
Misses ? 1402
Partials ? 68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bradenmacdonald
left a comment
There was a problem hiding this comment.
Works as described! I tested this on my Teak devstack.
* Add a warning banner about units in the libraries sync page. * Update the message in the sync unit modal. * Stay visible the sync icon in the course outline. * Add a tooltip to the edit (in normal and disabled mode) and sync button.
* Add a warning banner about units in the libraries sync page. * Update the message in the sync unit modal. * Stay visible the sync icon in the course outline. * Add a tooltip to the edit (in normal and disabled mode) and sync button.
* Add a warning banner about units in the libraries sync page. * Update the message in the sync unit modal. * Stay visible the sync icon in the course outline. * Add a tooltip to the edit (in normal and disabled mode) and sync button.
* Add a warning banner about units in the libraries sync page. * Update the message in the sync unit modal. * Stay visible the sync icon in the course outline. * Add a tooltip to the edit (in normal and disabled mode) and sync button.
* Add a warning banner about units in the libraries sync page. * Update the message in the sync unit modal. * Stay visible the sync icon in the course outline. * Add a tooltip to the edit (in normal and disabled mode) and sync button.
…2320) * Add a warning banner about units in the libraries sync page. * Update the message in the sync unit modal. * Stay visible the sync icon in the course outline. * Add a tooltip to the edit (in normal and disabled mode) and sync button.
…2320) * Add a warning banner about units in the libraries sync page. * Update the message in the sync unit modal. * Stay visible the sync icon in the course outline. * Add a tooltip to the edit (in normal and disabled mode) and sync button.
* Add a warning banner about units in the libraries sync page. * Update the message in the sync unit modal. * Stay visible the sync icon in the course outline. * Add a tooltip to the edit (in normal and disabled mode) and sync button.
* Add a warning banner about units in the libraries sync page. * Update the message in the sync unit modal. * Stay visible the sync icon in the course outline. * Add a tooltip to the edit (in normal and disabled mode) and sync button.
Description
Supporting information
Testing instructions
Content > Libraryupdated, and verify the new warning about unit updates