Skip to content

[Teak] style: Fixing nits about sync units [FC-0097] - #2320

Merged
ChrisChV merged 5 commits into
openedx:release/teakfrom
open-craft:chris/teak/unit-library-sync-nits
Aug 28, 2025
Merged

[Teak] style: Fixing nits about sync units [FC-0097]#2320
ChrisChV merged 5 commits into
openedx:release/teakfrom
open-craft:chris/teak/unit-library-sync-nits

Conversation

@ChrisChV

@ChrisChV ChrisChV commented Jul 22, 2025

Copy link
Copy Markdown
Contributor

Description

  • Add a warning banner about units in the libraries sync page.
image
  • Update the message in the sync unit modal.
  • Stay visible the sync icon in the course outline.
  • Add a tooltip to the edit (in normal and disabled mode) and sync button.
image

Supporting information

Testing instructions

  • Go to the library home of a library
  • Create a unit on a library. Publish the unit
  • Go to the course outline. Add the unit from the library.
  • Verify the new tooltip on the edit button.
  • Go to the library and update the unit name. Publish the unit
  • Go to the course outline and verify that the sync button stays visible on the unit card.
  • Click the sync button, verify the new message of the preview modal.
  • Verify new tooltip on the sync button.
  • Go to Content > Library updated, and verify the new warning about unit updates

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 22, 2025
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @ChrisChV!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Jul 22, 2025
@ChrisChV
ChrisChV force-pushed the chris/teak/unit-library-sync-nits branch from 457b995 to f4a92f7 Compare July 22, 2025 20:11
@ChrisChV
ChrisChV requested a review from bradenmacdonald July 22, 2025 20:12
@ChrisChV ChrisChV changed the title style: Fixing nits about sync units [FC-0097] [Teak] style: Fixing nits about sync units [FC-0097] Jul 22, 2025
* Stay visible the sync icon in the course outline
* Update the message in the sync unit modal
* Add warning banner about units in the libraries sync page
@ChrisChV
ChrisChV force-pushed the chris/teak/unit-library-sync-nits branch from f4a92f7 to 8dfc215 Compare July 22, 2025 20:32
@codecov

codecov Bot commented Jul 22, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release/teak@06497bf). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             release/teak    #2320   +/-   ##
===============================================
  Coverage                ?   93.90%           
===============================================
  Files                   ?     1149           
  Lines                   ?    24099           
  Branches                ?     5093           
===============================================
  Hits                    ?    22629           
  Misses                  ?     1402           
  Partials                ?       68           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mphilbrick211 mphilbrick211 added backport PR backports a change from main to a named release. FC Relates to an Axim Funded Contribution project labels Jul 28, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Jul 28, 2025

@bradenmacdonald bradenmacdonald left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described! I tested this on my Teak devstack.

@ChrisChV

Copy link
Copy Markdown
Contributor Author

CC @farhaanbukhsh

@ChrisChV
ChrisChV merged commit 41fc478 into openedx:release/teak Aug 28, 2025
7 checks passed
@github-project-automation github-project-automation Bot moved this from Ready for Review to Done in Contributions Aug 28, 2025
@ChrisChV
ChrisChV deleted the chris/teak/unit-library-sync-nits branch August 28, 2025 16:15
Asespinel pushed a commit to eduNEXT/frontend-app-course-authoring that referenced this pull request Dec 14, 2025
* Add a warning banner about units in the libraries sync page.
* Update the message in the sync unit modal.
* Stay visible the sync icon in the course outline.
* Add a tooltip to the edit (in normal and disabled mode) and sync button.
Asespinel pushed a commit to eduNEXT/frontend-app-course-authoring that referenced this pull request Dec 17, 2025
* Add a warning banner about units in the libraries sync page.
* Update the message in the sync unit modal.
* Stay visible the sync icon in the course outline.
* Add a tooltip to the edit (in normal and disabled mode) and sync button.
Asespinel pushed a commit to eduNEXT/frontend-app-course-authoring that referenced this pull request Dec 17, 2025
* Add a warning banner about units in the libraries sync page.
* Update the message in the sync unit modal.
* Stay visible the sync icon in the course outline.
* Add a tooltip to the edit (in normal and disabled mode) and sync button.
Asespinel pushed a commit to eduNEXT/frontend-app-course-authoring that referenced this pull request Dec 17, 2025
* Add a warning banner about units in the libraries sync page.
* Update the message in the sync unit modal.
* Stay visible the sync icon in the course outline.
* Add a tooltip to the edit (in normal and disabled mode) and sync button.
Asespinel pushed a commit to eduNEXT/frontend-app-course-authoring that referenced this pull request Dec 18, 2025
* Add a warning banner about units in the libraries sync page.
* Update the message in the sync unit modal.
* Stay visible the sync icon in the course outline.
* Add a tooltip to the edit (in normal and disabled mode) and sync button.
xitij2000 pushed a commit to open-craft/frontend-app-authoring that referenced this pull request Dec 19, 2025
…2320)

* Add a warning banner about units in the libraries sync page.
* Update the message in the sync unit modal.
* Stay visible the sync icon in the course outline.
* Add a tooltip to the edit (in normal and disabled mode) and sync button.
xitij2000 pushed a commit to open-craft/frontend-app-authoring that referenced this pull request Dec 19, 2025
…2320)

* Add a warning banner about units in the libraries sync page.
* Update the message in the sync unit modal.
* Stay visible the sync icon in the course outline.
* Add a tooltip to the edit (in normal and disabled mode) and sync button.
xitij2000 pushed a commit to open-craft/frontend-app-authoring that referenced this pull request Dec 19, 2025
* Add a warning banner about units in the libraries sync page.
* Update the message in the sync unit modal.
* Stay visible the sync icon in the course outline.
* Add a tooltip to the edit (in normal and disabled mode) and sync button.
xitij2000 pushed a commit to open-craft/frontend-app-authoring that referenced this pull request Dec 19, 2025
* Add a warning banner about units in the libraries sync page.
* Update the message in the sync unit modal.
* Stay visible the sync icon in the course outline.
* Add a tooltip to the edit (in normal and disabled mode) and sync button.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport PR backports a change from main to a named release. FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants