Skip to content

feat: add new unit test to check if request data is formatted in updateCourseAdvancedSettings #2193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jignaciopm wants to merge 1 commit into from
Closed

feat: add new unit test to check if request data is formatted in updateCourseAdvancedSettings #2193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions src/advanced-settings/data/api.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,55 @@ describe('courseSettings API', () => {
);
expect(result).toEqual(expected);
});

it('should be updated with the request data formatted in snake_case', async () => {
const fakeSettingData = {
advancedModules: ['poll', 'problem-builder', 'h5pxblock'],
testCamelCase: 'To come snake_case',
PascalCase: true,
'kebab-case': {
nestedOption: 'This key must not be formatted',
},
UPPER_CASE: 'To come snake_case',
lowercase: 'This key must not be formatted', // because snake_case in lowercase not formatted
UPPERCASE: 'To come lowercase', // because snake_case in UPPERCASE format to lowercase
'Title Case': 'To come snake_case',
'dot.case': 'To come snake_case',
SCREAMING_SNAKE_CASE: 'To come snake_case',
MixedCase: 'To come snake_case',
'Train-Case': 'To come snake_case',
nestedOption: {
anotherOption: 'This key must not be formatted',
},
};
const expected = {
advanced_modules: { value: ['poll', 'problem-builder', 'h5pxblock'] },
test_camel_case: { value: 'To come snake_case' },
pascal_case: { value: true },
kebab_case: {
value: { nestedOption: 'This key must not be formatted' },

@bradenmacdonald bradenmacdonald Jun 19, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we have a value with a nested option in snake_case ?

},
upper_case: { value: 'To come snake_case' },
lowercase: { value: 'This key must not be formatted' }, // because snake_case in lowercase not formatted
uppercase: { value: 'To come lowercase' }, // because snake_case in UPPERCASE format to lowercase
title_case: { value: 'To come snake_case' },
dot_case: { value: 'To come snake_case' },
screaming_snake_case: { value: 'To come snake_case' },
mixed_case: { value: 'To come snake_case' },
train_case: { value: 'To come snake_case' },
nested_option: {
value: { anotherOption: 'This key must not be formatted' },
},
};

mockHttpClient.patch.mockResolvedValue({ data: {} });

await updateCourseAdvancedSettings('course-v1:Test+T101+2024', fakeSettingData);
expect(mockHttpClient.patch).toHaveBeenCalledWith(
`${process.env.STUDIO_BASE_URL}/api/contentstore/v0/advanced_settings/course-v1:Test+T101+2024`,
expected,
);
});
});

describe('getProctoringExamErrors', () => {
Expand Down