test: replacing snapshot tests with rtl tests part 6 - #2173
Conversation
|
Thanks for the pull request, @jacobo-dominguez-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2173 +/- ##
========================================
Coverage 94.08% 94.08%
========================================
Files 1164 1164
Lines 24475 24477 +2
Branches 5187 5320 +133
========================================
+ Hits 23027 23030 +3
+ Misses 1380 1370 -10
- Partials 68 77 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
401ac2b to
27f9c5b
Compare
bradenmacdonald
left a comment
There was a problem hiding this comment.
Nice, thank you!
This pr is replacing shallow and snapshot tests with rtl tools in order to depracate @edx/react-unit-test-utils package.
Issue #2116
UT affected for this pr:
The snapshots related to these tests were removed.
The tests were turned into typescript files.
The components related to the tests that were using the deprecated HOC of
injectIntlwere refactored to useuseIntl.1 snapshot was updated due to the intl refactor (Will be removed in the future).