Skip to content

fix: show "This <containerType> is empty" [FC-0090] - #2157

Merged
ChrisChV merged 1 commit into
openedx:masterfrom
open-craft:jill/empty-container
Jun 16, 2025
Merged

fix: show "This <containerType> is empty" [FC-0090]#2157
ChrisChV merged 1 commit into
openedx:masterfrom
open-craft:jill/empty-container

Conversation

@pomegranited

Copy link
Copy Markdown
Contributor

Description

Shows "This is empty" text when container child list is empty for units, subsections, and sections.

Affects Content Library Authors.

Supporting information

Addresses comments:

Private-ref: FAL-4191

Testing instructions

  1. In a content library, create a new empty Unit, Subsection, and Section.
  2. From the main library page, click through each of the empty container cards and check that expected text displays in the sidebar preview, e.g "This unit is empty
  3. Open each empty container -- empty text from the sidebar preview above should display on the page.

when container child list is empty for units, subsections, and sections.
@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Jun 16, 2025
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @pomegranited!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov

codecov Bot commented Jun 16, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.07%. Comparing base (eaee525) to head (c643e8e).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2157      +/-   ##
==========================================
- Coverage   94.07%   94.07%   -0.01%     
==========================================
  Files        1164     1164              
  Lines       24473    24477       +4     
  Branches     5320     5303      -17     
==========================================
+ Hits        23023    23026       +3     
- Misses       1373     1374       +1     
  Partials       77       77              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ChrisChV ChrisChV left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

  • I tested this: I followed the testing instructions and verified that the tests are gone
  • I read through the code and considered the security, stability and performance implications of the changes.
  • I tested that the UI can be used with a keyboard only (tab order, keyboard controls).
  • Includes tests for bugfixes and/or features added.
  • Includes documentation

@ChrisChV
ChrisChV merged commit fa9d66c into openedx:master Jun 16, 2025
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Contributions Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants