fix:remove duplicate markdown_edited save request - #2112
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @Anas12091101! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
8453c82 to
1cdc974
Compare
1cdc974 to
f07648a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2112 +/- ##
==========================================
- Coverage 94.03% 94.03% -0.01%
==========================================
Files 1163 1163
Lines 24424 24423 -1
Branches 5294 5180 -114
==========================================
- Hits 22968 22967 -1
Misses 1388 1388
Partials 68 68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| dispatch(actions.problem.updateField({ isMarkdownEditorEnabled: true })); | ||
| const { blockValue } = state.app; | ||
| const olx = get(blockValue, 'data.data', ''); | ||
| const content = { settings: { markdown_edited: true }, olx }; |
There was a problem hiding this comment.
Just confirming... it is not necessary to set markdown_editor: true? Does something else take care of this?
There was a problem hiding this comment.
Yes, we’re also setting the markdown_edited value in the parseState function. That’s what returns the payload used when saving a problem.
Removes the unnecessary duplicate save request of markdown_edited value to the backend. Part of: openedx#2099 Will be backported to Teak.
3 participants
Description
This PR fixes the issue in #2099 by removing the unnecessary duplicate save request of
markdown_editedvalue to the backend.Useful information to include:
changes.
Supporting information
#2099
Testing instructions
Course Testing:
Library Testing:
Other information
Include anything else that will help reviewers and consumers understand the change.