Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/generic/inplace-text-editor/InplaceTextEditor.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -110,4 +110,25 @@ describe('<InplaceTextEditor />', () => {
// Show original text
expect(screen.getByText('Test text')).toBeInTheDocument();
});

it('should disappear edit button while editing', async () => {
render(<InplaceTextEditor text="Test text" onSave={mockOnSave} />);

const title = screen.getByText('Test text');
expect(title).toBeInTheDocument();

const editButton = screen.getByRole('button', { name: /edit/i });
expect(editButton).toBeInTheDocument();
fireEvent.click(editButton);

const textBox = screen.getByRole('textbox');
expect(editButton).not.toBeInTheDocument();

fireEvent.change(textBox, { target: { value: 'New text' } });
fireEvent.keyDown(textBox, { key: 'Enter', code: 'Enter', charCode: 13 });

expect(textBox).not.toBeInTheDocument();
expect(mockOnSave).toHaveBeenCalledWith('New text');
expect(await screen.findByRole('button', { name: /edit/i })).toBeInTheDocument();
});
});
22 changes: 12 additions & 10 deletions src/generic/inplace-text-editor/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -92,17 +92,19 @@ export const InplaceTextEditor: React.FC<InplaceTextEditorProps> = ({
/>
)
: (
<Truncate className={textClassName}>
{text}
</Truncate>
<>
<Truncate className={textClassName}>
{text}
</Truncate>
<IconButton
src={Edit}
iconAs={Icon}
alt={intl.formatMessage(messages.editTextButtonAlt)}
onClick={handleEdit}
size="sm"
/>
</>
)}
<IconButton
src={Edit}
iconAs={Icon}
alt={intl.formatMessage(messages.editTextButtonAlt)}
onClick={handleEdit}
size="inline"
/>
</Stack>
);
};
2 changes: 1 addition & 1 deletion src/library-authoring/LibraryAuthoringPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ export const SubHeaderTitle = ({ title }: { title: ReactNode }) => {
const showReadOnlyBadge = readOnly && !componentPickerMode;

return (
<Stack direction="vertical">
<Stack direction="vertical" className="mt-1.5">
{title}
{showReadOnlyBadge && (
<div>
Expand Down
2 changes: 1 addition & 1 deletion src/library-authoring/data/apiHooks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -619,7 +619,7 @@ export const useUpdateContainer = (containerId: string) => {
return useMutation({
mutationFn: (data: api.UpdateContainerDataRequest) => api.updateContainerMetadata(containerId, data),
onMutate: (data) => {
const previousData = queryClient.getQueryData(containerQueryKey) as api.CollectionMetadata;
const previousData = queryClient.getQueryData(containerQueryKey) as api.Container;
queryClient.setQueryData(containerQueryKey, {
...previousData,
...data,
Expand Down