Skip to content

Add html lang prop to CodeEditor Component inside the SourceCodeModal #2043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brian-smith-tcril merged 4 commits into from
Jun 2, 2025
Merged

Add html lang prop to CodeEditor Component inside the SourceCodeModal #2043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b9ee3ca
fix: hardcoded the html lang onto the CodeEditor component inside the…
tonybusa May 29, 2025
51467ca
chore: update SourceCodeModal snapshot to account for html lang imple…
tonybusa May 29, 2025
245024e
chore: added inline comments for the explaining changes of hardcoded …
tonybusa May 29, 2025
8248abb
revert changes on test
tonybusa May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/editors/sharedComponents/SourceCodeModal/__snapshots__/index.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ exports[`SourceCodeModal renders as expected with default behavior 1`] = `
>
<injectIntl(ShimmedIntlComponent)
innerRef="moCKrEf"
lang="html"
Comment thread
tonybusa marked this conversation as resolved.
value="mOckHtMl"
/>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/editors/sharedComponents/SourceCodeModal/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import React from 'react';
import PropTypes from 'prop-types';

import {
Expand Down Expand Up @@ -41,6 +40,7 @@ const SourceCodeModal = ({
<CodeEditor
innerRef={ref}
value={value}
lang="html" // hardcoded value to do lookup on CODEMIRROR_LANGUAGES
/>
</div>
</BaseModal>
Expand Down