Skip to content

[TEAK] fix: set maxHeight on TextEditor TinyMce widget [FC-0090] #2030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisChV merged 1 commit into from
May 26, 2025
+6 −4
Merged

[TEAK] fix: set maxHeight on TextEditor TinyMce widget [FC-0090] #2030

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/editors/containers/TextEditor/__snapshots__/index.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,13 @@ exports[`TextEditor snapshots block failed to load, Toast is shown 1`] = `
}
editorType="text"
enableImageUpload={true}
height="100%"
id={null}
images={{}}
initializeEditor={[MockFunction args.intializeEditor]}
isLibrary={null}
learningContextId="course+org+run"
lmsEndpointUrl=""
maxHeight={500}
minHeight={500}
onChange={[Function]}
setEditorRef={[MockFunction hooks.prepareEditorRef.setEditorRef]}
Expand Down Expand Up @@ -226,13 +226,13 @@ exports[`TextEditor snapshots renders as expected with default behavior 1`] = `
}
editorType="text"
enableImageUpload={true}
height="100%"
id={null}
images={{}}
initializeEditor={[MockFunction args.intializeEditor]}
isLibrary={null}
learningContextId="course+org+run"
lmsEndpointUrl=""
maxHeight={500}
minHeight={500}
onChange={[Function]}
setEditorRef={[MockFunction hooks.prepareEditorRef.setEditorRef]}
Expand Down Expand Up @@ -292,13 +292,13 @@ exports[`TextEditor snapshots renders static images with relative paths 1`] = `
}
editorType="text"
enableImageUpload={true}
height="100%"
id={null}
images={{}}
initializeEditor={[MockFunction args.intializeEditor]}
isLibrary={null}
learningContextId="course+org+run"
lmsEndpointUrl=""
maxHeight={500}
minHeight={500}
onChange={[Function]}
setEditorRef={[MockFunction hooks.prepareEditorRef.setEditorRef]}
Expand Down
2 changes: 1 addition & 1 deletion src/editors/containers/TextEditor/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ const TextEditor = ({
editorContentHtml={editorContent}
setEditorRef={setEditorRef}
minHeight={500}
height="100%"
maxHeight={500}
initializeEditor={initializeEditor}
{...{
images,
Expand Down
2 changes: 2 additions & 0 deletions src/editors/sharedComponents/TinyMceWidget/hooks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,7 @@ export const editorConfig = ({
updateContent,
content,
minHeight,
maxHeight,
learningContextId,
staticRootUrl,
enableImageUpload,
Expand Down Expand Up @@ -335,6 +336,7 @@ export const editorConfig = ({
content_css: false,
content_style: tinyMCEStyles + a11ycheckerCss,
min_height: minHeight,
max_height: maxHeight,
contextmenu: 'link table',
directionality: isLocaleRtl ? 'rtl' : 'ltr',
document_base_url: baseURL,
Expand Down