chore: remove unused dependencies "npm" and "start" - #1931
Conversation
|
Thanks for the pull request, @bradenmacdonald! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1931 +/- ##
=======================================
Coverage 93.82% 93.82%
=======================================
Files 1150 1150
Lines 24054 24054
Branches 5193 5194 +1
=======================================
Hits 22568 22568
Misses 1409 1409
Partials 77 77 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ChrisChV
left a comment
There was a problem hiding this comment.
Looks good 👍
- I tested this: I testes that the projects runs correctly
- I read through the code and considered the security, stability and performance implications of the changes.
Description
These two dependencies
npmandstartwere accidentally added in #1133 . I'm pretty sure someone typednpm startwhennpm installwas already in their terminal :pAnd wow, 2 deleted lines in
package.jsonresults in 2,500+ lines removed frompackage-lock.json!Private ref: MNG-4670