Skip to content

[Backport] fix: pages and resources plugins not rendered - #1886

Closed
brian-smith-tcril wants to merge 1 commit into
openedx:release/teak.masterfrom
brian-smith-tcril:backport-plugin-fix
Closed

[Backport] fix: pages and resources plugins not rendered#1886
brian-smith-tcril wants to merge 1 commit into
openedx:release/teak.masterfrom
brian-smith-tcril:backport-plugin-fix

Conversation

@brian-smith-tcril

Copy link
Copy Markdown
Contributor

Backport of #1885

@codecov

codecov Bot commented Apr 30, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.04%. Comparing base (b30a1c8) to head (594c851).

Additional details and impacted files
@@                   Coverage Diff                   @@
##           release/teak.master    #1886      +/-   ##
=======================================================
+ Coverage                93.77%   94.04%   +0.27%     
=======================================================
  Files                     1146     1152       +6     
  Lines                    23905    25999    +2094     
  Branches                  5043     5782     +739     
=======================================================
+ Hits                     22416    24452    +2036     
- Misses                    1421     1464      +43     
- Partials                    68       83      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@brian-smith-tcril brian-smith-tcril added the backport PR backports a change from main to a named release. label May 1, 2025

@farhaanbukhsh farhaanbukhsh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • ✅ I tested this on local sandbox and this looks good to me.
  • ✅ I read through the code
  • ❌ I checked for accessibility issues
  • ❌ Includes documentation

@farhaanbukhsh
farhaanbukhsh deleted the branch openedx:release/teak.master May 19, 2025 15:59
@mariajgrimaldi

Copy link
Copy Markdown
Member

This PR was closed when we deleted the release/teak.master branch in favor of release/teak. Should we reopen it?

@farhaanbukhsh

Copy link
Copy Markdown
Member

@mariajgrimaldi yes we should!

@brian-smith-tcril

Copy link
Copy Markdown
Contributor Author

I couldn't reopen this because the target branch was renamed, so I made a new PR #2307

@farhaanbukhsh

Copy link
Copy Markdown
Member

thanks @mariajgrimaldi and @brian-smith-tcril :) Merged it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport PR backports a change from main to a named release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants