Skip to content

fix: load sequences in unit page - #1876

Closed
ihor-romaniuk wants to merge 3 commits into
openedx:release/teak.masterfrom
raccoongang:romaniuk/fix/load-sequences-teak
Closed

fix: load sequences in unit page#1876
ihor-romaniuk wants to merge 3 commits into
openedx:release/teak.masterfrom
raccoongang:romaniuk/fix/load-sequences-teak

Conversation

@ihor-romaniuk

@ihor-romaniuk ihor-romaniuk commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

Description

Handle loading errors when opening the course unit page via direct link as an unauthorized user.

Original pull request:

Screenshots

Case 1: Open course unit page
image

Case 2: Open Split Test xblock content
image

Unexpected Application Error!
Cannot read properties of undefined (reading 'upstreamLink')
TypeError: Cannot read properties of undefined (reading 'upstreamLink')
    at T2 (https://app.pr-1788-ba9a65.sandboxes.opencraft.hosting/authoring/app.a1ce6d6e6800b33ff46c.js:1:5941058)
    at pa (https://app.pr-1788-ba9a65.sandboxes.opencraft.hosting/authoring/457.db97dc1cceb0d252ed30.js:2:1924360)
    at ks (https://app.pr-1788-ba9a65.sandboxes.opencraft.hosting/authoring/457.db97dc1cceb0d252ed30.js:2:1938398)
    at wu (https://app.pr-1788-ba9a65.sandboxes.opencraft.hosting/authoring/457.db97dc1cceb0d252ed30.js:2:1984168)
    at gl (https://app.pr-1788-ba9a65.sandboxes.opencraft.hosting/authoring/457.db97dc1cceb0d252ed30.js:2:1972553)
    at hl (https://app.pr-1788-ba9a65.sandboxes.opencraft.hosting/authoring/457.db97dc1cceb0d252ed30.js:2:1972481)
    at pl (https://app.pr-1788-ba9a65.sandboxes.opencraft.hosting/authoring/457.db97dc1cceb0d252ed30.js:2:1972344)
    at nl (https://app.pr-1788-ba9a65.sandboxes.opencraft.hosting/authoring/457.db97dc1cceb0d252ed30.js:2:1969179)
    at tl (https://app.pr-1788-ba9a65.sandboxes.opencraft.hosting/authoring/457.db97dc1cceb0d252ed30.js:2:1967735)
    at _ (https://app.pr-1788-ba9a65.sandboxes.opencraft.hosting/authoring/457.db97dc1cceb0d252ed30.js:2:1005861)

Testing instructions

  • Open the course unit page directly while not signed in.
  • Sign in to the system.
  • Case 1
    -- Verify that the course unit page loads correctly after authentication.
  • Case 2
    -- Add Split Test xBlock
    -- Open Split Test xBlock content page
    -- Verify that the Split Test xBlock content page loads correctly.

Other information

Settings

EDX_PLATFORM_REPOSITORY: https://github.com/openedx/edx-platform.git
EDX_PLATFORM_VERSION: release/teak.master

TUTOR_GROVE_WAFFLE_FLAGS:
  - name: contentstore.new_studio_mfe.use_new_unit_page
    everyone: true

TUTOR_GROVE_NEW_MFES:
  authoring:
    port: 18000
    repository: https://github.com/raccoongang/frontend-app-course-authoring.git
    version: romaniuk/fix/load-sequences-teak

TUTOR_GROVE_MFE_LMS_COMMON_SETTINGS: |
  MFE_CONFIG["ENABLE_UNIT_PAGE"] = True
  MFE_CONFIG["ENABLE_NEW_EDITOR_PAGES"] = True

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 29, 2025
@openedx-webhooks

openedx-webhooks commented Apr 29, 2025

Copy link
Copy Markdown

Thanks for the pull request, @ihor-romaniuk!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov

codecov Bot commented Apr 29, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (release/teak.master@1919eb4). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/course-unit/data/thunk.js 91.66% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##             release/teak.master    #1876   +/-   ##
======================================================
  Coverage                       ?   93.79%           
======================================================
  Files                          ?     1147           
  Lines                          ?    23965           
  Branches                       ?     5073           
======================================================
  Hits                           ?    22478           
  Misses                         ?     1419           
  Partials                       ?       68           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@peterkulko peterkulko added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Apr 30, 2025
@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label May 1, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions May 1, 2025
@ihor-romaniuk
ihor-romaniuk force-pushed the romaniuk/fix/load-sequences-teak branch 2 times, most recently from 07868b7 to 0b9ed3b Compare May 9, 2025 16:12
@ihor-romaniuk ihor-romaniuk added create-sandbox open-craft-grove should create a sandbox environment from this PR and removed create-sandbox open-craft-grove should create a sandbox environment from this PR labels May 9, 2025
@ihor-romaniuk
ihor-romaniuk force-pushed the romaniuk/fix/load-sequences-teak branch from 0b9ed3b to 6aeabd1 Compare May 16, 2025 10:40
@farhaanbukhsh
farhaanbukhsh deleted the branch openedx:release/teak.master May 19, 2025 15:59
@github-project-automation github-project-automation Bot moved this from Ready for Review to Done in Contributions May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport PR backports a change from main to a named release. create-sandbox open-craft-grove should create a sandbox environment from this PR open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants