fix: Error when viewing text component in RAW HTML - #1869
Merged
rayzhou-bit merged 1 commit intoApr 28, 2025
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1869 +/- ##
========================================
Coverage 93.77% 93.78%
========================================
Files 1146 1146
Lines 23898 23898
Branches 5040 5145 +105
========================================
+ Hits 22411 22412 +1
+ Misses 1419 1409 -10
- Partials 68 77 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rayzhou-bit
suggested changes
Apr 28, 2025
This commit fixes the error when viewing text component in RAW HTML as `lang` was passed `undefined` and `CODEMIRROR_LANGUAGES[lang]()` was throwing this: `TypeError: Ap[i] is not a function`
Faraz32123
force-pushed
the
faraz/fix-error_when_viewing_text_component_in_raw_html
branch
from
April 28, 2025 16:51
08e6e7d to
f382ace
Compare
rayzhou-bit
approved these changes
Apr 28, 2025
rayzhou-bit
deleted the
faraz/fix-error_when_viewing_text_component_in_raw_html
branch
April 28, 2025 20:51
Contributor
|
FYI @Anas12091101. No action needed. |
This was referenced Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: TNL-11959
langwas passedundefinedandCODEMIRROR_LANGUAGES[lang]()was throwing this:TypeError: Ap[i] is not a functionBefore:
After: