WIP [TNL-11898] feat: add multiple problem editor UI - #1702
Closed
hinakhadim wants to merge 2 commits into
Closed
Conversation
hinakhadim
marked this pull request as draft
March 4, 2025 08:18
| }; | ||
|
|
||
| export const ShuffleCardInternal = ShuffleCard; // For testing only | ||
| export default injectIntl(ShuffleCard); |
Contributor
There was a problem hiding this comment.
If you are adding entirely new files, please follow the current best practices:
- Use TypeScript .TSX instead of .JSX
- Use TypeScript instead of
propTypes - Use
useIntlinstead ofinjectIntl- Just have
ShuffleCard, no need forShuffleCardInternal
- Just have
Contributor
Author
There was a problem hiding this comment.
Thanks for sharing. I'll update the code.
|
|
||
| QuestionItem.propTypes = { | ||
| }; | ||
| QuestionItem.defaultProps = { |
Contributor
There was a problem hiding this comment.
Same comment here about following newer practices in new files.
Also, defaultProps is deprecated; please avoid it entirely.
hinakhadim
force-pushed
the
TNL-11898/implement-multi-problem-editor-ui
branch
from
March 5, 2025 11:41
16bbcf9 to
314c219
Compare
Contributor
|
It looks like this is very similar to #1805 and most of the concerns mentioned in this PR have been resolved, so I'm going to close this. Let me know if we need to re-open. |
bradenmacdonald
deleted the
TNL-11898/implement-multi-problem-editor-ui
branch
August 26, 2025 18:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new feature implementing the Multi-Problem Editor UI.
Previously, course authors had to add questions one by one, which was a time-consuming process. Each time an author wanted to add a question, they had to:
With this new UI, the author will only need to click on the problem tile once. A new window will open where they can add multiple questions within the same interface and save them, significantly improving the authoring experience.
JIRA Link
Figma Link
Which edX user roles will this change impact? Common user roles are "Course Author".
What's Next or TODOs:
FormattedMessageComponentHow to setup on local devstack
edx.orgtheme for MFEs (If not, steps are mentioned here for setting up)npm startScreenshot
Before
After
Other information
Include anything else that will help reviewers and consumers understand the change.