fix: fixed Configure modal for Course Unit page

[peterkulko]

Description

Fixed behavior of the configuration modal window on the course unit page

Issue: #1429

Testing instructions

1. Open the new Course unit page.
2. Open the configuration modal for the unit/XBlock.
3. After saving, the configuration modal is closed.
4. For XBlock configuration modal, the Discussions checkbox is hidden.
5. For the unit configuration modal, the Discussions checkbox is visible and can be saved.

Screen.Recording.2024-11-15.at.12.14.31.mov

[openedx-webhooks]

Thanks for the pull request, @PKulkoRaccoonGang!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.22%. Comparing base (e118eb5) to head (72a754a).
Report is 15 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1452      +/-   ##
==========================================
- Coverage   93.27%   93.22%   -0.05%     
==========================================
  Files        1052     1048       -4     
  Lines       20503    20397     -106     
  Branches     4312     4290      -22     
==========================================
- Hits        19125    19016     -109     
- Misses       1318     1319       +1     
- Partials       60       62       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[open-craft-grove]

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

[bradenmacdonald]

This looks fine, but I see some issues:

(1) This modal is called configure-modal and this component is called UnitTab. Why are we also using it for the "Manage Access" modal that XBlocks have? It seems like the only reason is that both modals have the same "user partition visibility" widget:

But this makes the code messy and more likely to have bugs like this.

I think it could be cleaner to have completely separate ConfigureModal and ManageBlockAccessModal components, and move the shared "user partition" widget to be a shared component, rather than using the Unit ConfigureModal for two different things and using the isXBlockComponent prop to alter it.

(2) After this change, if the user doesn't have any partition groups configured, the "Manage Access" modal is empty by default:

It should display an "empty state" message like the legacy UI does:

---

These don't have to block this PR; I know they're out of scope for this specific bugfix. You will need to rebase it before it can merge though.

[open-craft-grove]

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

[arbrandes]

Works for me!