-
Notifications
You must be signed in to change notification settings - Fork 210
feat: add onComponentSelected callback function and componentPickerMode types [FC-0062] #1417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bradenmacdonald
merged 10 commits into
openedx:master
from
open-craft:rpenido/fal-3901-component-picker-refactor
Oct 22, 2024
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
21423e3
refactor: add onComponentSelected callback function
rpenido 0831ba7
feat: add 'single' and 'multiple' componentPickerModes
rpenido 972845e
refactor: add narrow types
rpenido 037ffcf
fix: component picker select components
rpenido 2d0789f
test: add tests
rpenido eacea58
Merge branch 'master' into rpenido/fal-3901-component-picker-refactor
rpenido 089a76c
Merge branch 'master' into rpenido/fal-3901-component-picker-refactor
rpenido 4b74129
test: improve coverage
rpenido 6ebde8b
Merge branch 'master' into rpenido/fal-3901-component-picker-refactor
rpenido e755b62
feat: changes to support multi-select in legacy UI
bradenmacdonald File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
typechange is not very pretty on this side, but I think it is beneficial, as we add many related states in the context. It makes things safer using theuseLibraryContexthook on the components side.i.e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's nice. But I think we will soon need to split up
LibraryContextbecause it's getting too big and messy. We can instead haveLibraryContext,SidebarContext, andComponentPickerContext, and it will clean up our tests a lot too. TheSidebarContext, andComponentPickerContextcan both have defaults so they don't always have to be present in order to read their values. (e.g.isSidebarOpencan just be false in the default context, even if there's noSidebarContextProvideravailable)