Improve LibraryContext, convert tests to testUtils [FC-0062] - #1345
Conversation
|
Thanks for the pull request, @bradenmacdonald! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
1 similar comment
|
Thanks for the pull request, @bradenmacdonald! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1345 +/- ##
==========================================
+ Coverage 92.95% 92.97% +0.01%
==========================================
Files 1037 1036 -1
Lines 19508 19448 -60
Branches 4132 4133 +1
==========================================
- Hits 18134 18081 -53
+ Misses 1312 1302 -10
- Partials 62 65 +3 ☔ View full report in Codecov by Sentry. |
d6edc2e to
349080d
Compare
349080d to
7924f5a
Compare
pomegranited
left a comment
There was a problem hiding this comment.
👍 Deeply satisfying cleanup here, thank you @bradenmacdonald !
- I tested this on my tutor dev stack by verifying that basic library authoring features still work as expected.
- I read through the code
-
I checked for accessibility issuesN/A -
Includes documentationN/A -
User-facing strings are extracted for translationN/A
rpenido
left a comment
There was a problem hiding this comment.
LGTM 👍
Great work here, @bradenmacdonald!
- I tested this by checking the library authoring pages
- I read through the code
- I checked for accessibility issues
- Includes documentation
…1345) * feat(AU-1949): Restrict WCT to verified track learners only * fix: use jest-when * fix: clean tests
Description
This PR simplifies some of the library code by moving
libraryIdinto theLibraryContext. So components can be simplified like this:... and no longer have to pass
libraryIdusing "prop drilling".This PR is purely a code refactor to pave the way for some changes I need to make to
LibraryContextin a following PR. There are no changes to functionality. It removes 82 lines of code 😎.This is part of my work toward #1321
Private ref: FAL-3861