feat: implement SHOW_REGISTRATION_LINKS setting - #1065
Closed
CefBoud wants to merge 1 commit into
Closed
Conversation
|
Thanks for the pull request, @CefBoud! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate. |
CefBoud
marked this pull request as draft
October 2, 2023 10:17
|
@CefBoud Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
jignaciopm
pushed a commit
to eduNEXT/frontend-app-authn
that referenced
this pull request
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the newly added SHOW_REGISTRATION_LINKS setting whose purpose is to hide the public registration functionality without disabling the register API.
ALLOW_PUBLIC_ACCOUNT_CREATIONis already taken into account in thefrontend-app-authnand is expected to be set through the runtime configuration.This PR introduces the possibility of adding the
SHOW_REGISTRATION_LINKSsetting to the MFE runtime config so it can be taken into account for hiding the register functionality without disabling the API, thus replicating the legacy LMS flow.How Has This Been Tested?
The steps to test are as follows:
ENABLE_MFE_CONFIG_APIto True in the LMS settingsSHOW_REGISTRATION_LINKSto False in theMFE_CONFIGdict in the LMS settingsMFE_CONFIG_API_URLto 'http://localhost:18000/api/mfe_config/v1' in.env.developmentto enable runtime confregistertab.NB: mind the
MFE_CONFIG_API_CACHE_TIMEOUTsetting if you want to play around withMFE_CONFIG. The result is cached for 5min by default. The runtime config also relies on client-side caching, so better to rely on private browsing if there is a config change.Screenshots/sandbox (optional):
Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if its not applicable.
Merge Checklist
Post-merge Checklist