Skip to content

Conversation

@brian-smith-tcril
Copy link
Contributor

@brian-smith-tcril brian-smith-tcril commented May 8, 2024

@codecov
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 56.70%. Comparing base (9693d93) to head (9c5dfae).
Report is 14 commits behind head on master.

❗ Current head 9c5dfae differs from pull request most recent head 1fa9791. Consider uploading reports for the commit 1fa9791 to get more accurate results

Files Patch % Lines
src/plugin-slots/FooterSlot/index.jsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1044      +/-   ##
==========================================
+ Coverage   56.55%   56.70%   +0.14%     
==========================================
  Files         117      120       +3     
  Lines        2456     2499      +43     
  Branches      654      673      +19     
==========================================
+ Hits         1389     1417      +28     
- Misses        996     1008      +12     
- Partials       71       74       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is still a draft, but for what it's worth, I think this is the way to go. No objections!

@brian-smith-tcril brian-smith-tcril marked this pull request as ready for review May 9, 2024 17:12
@arbrandes arbrandes merged commit d1e817d into openedx:master May 9, 2024
@arbrandes
Copy link
Contributor

We missed the Redwood cutoff but exactly 60 seconds. 🤷🏼‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants