Add support for the edx.course.enrollment.mode_changed event - #304
Conversation
|
Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
|
This makes sense to me, is it good to come out of draft status? |
|
Looks like some issues with the docs too: |
|
Thank you for the input @bmtcril! I'm looking into the docs and Testing Instructions. This PR will also need to increment the version number, right? Right know, I'm having issues dispatching the event (probably related to my stack, not the code itself) This is my statement_data: {
"id":"0e3fcdb0-a003-5403-8f4d-c48a97987b8d",
"version":"1.0.3",
"actor":{
"objectType":"Agent",
"account":{
"name":"bf1b9a01-5ca9-4f2f-be97-13df6ef42731",
"homePage":"http://localhost:18000"
}
},
"verb":{
"id":"http://adlnet.gov/expapi/verbs/registered",
"display":{
"en":"registered"
}
},
"object":{
"id":"http://localhost:18000/course/course-v1:edX+DemoX+Demo_Course",
"objectType":"Activity",
"definition":{
"name":{
"en":"Demonstration Course"
},
"type":"http://adlnet.gov/expapi/activities/course",
"extensions":{
"https://w3id.org/xapi/acrossx/extensions/type":"audit"
}
}
},
"timestamp":"2023-06-05T17:52:16.204763+00:00",
"context":{
"extensions":{
"https://w3id.org/xapi/openedx/extension/transformer-version":"event-routing-backends@5.3.1"
}
}
}I'm investigating the issue. Thank you! |
pomegranited
left a comment
There was a problem hiding this comment.
👍 This is working perfectly @rpenido :)
Just a couple of minor nits and a version bump and it's ready to merge.
- I tested this using my Tutor OARS devstack, with the LMS image rebuilt to use this branch.
- Enrolled in the DemoX course
- From the LMS shell, ran:
python manage.py lms change_enrollment -e superuser@example.com -f audit -t honor -c 'course-v1:edX+DemoX+Demo_Course' - Watched this event appear on the OARS xAPI events chart, complete with the
honorcourse mode in the event.
- I read through the code
-
I checked for accessibility issuesN/A backend only - Includes documentation, and the links are working.
- Commit structure follows OEP-0051
|
@ziafazal are we good to merge this and roll a release? |
|
@bmtcril let me merge and create release. |
|
@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description: Add support for the
edx.course.enrollment.mode_changedevent. Use the same verb and transformer thanedx.course.enrollment.activatedVerb
Closes #292
Merge checklist: