Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with karma hanging on exit #54

Merged
merged 4 commits into from
Apr 6, 2016
Merged

Fix issues with karma hanging on exit #54

merged 4 commits into from
Apr 6, 2016

Conversation

bjacobel
Copy link
Contributor

@bjacobel bjacobel commented Apr 5, 2016

See issue here. karma-coverage with reporters text and text-summary and our setup for some reason has an issue where it will hang for ~30 seconds prior to exiting. Since coverage reports are only marginally helpful in development, this PR removes the text-summary reporter. (It doesn't affect Coveralls.)

Also tweaks a few other things around the Karma setup:

  • adds ability to run tests with npm test, which means you don't need to install Gulp globally
  • removes a library that wasn't doing anything
  • fixes linting issues

cc @andy-armstrong

@andy-armstrong
Copy link
Contributor

👍 Thanks for tracking this down as it had been bothering me too.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.874% when pulling 3258744 on fix-karma-hang into 9759688 on master.

@bjacobel bjacobel merged commit cc2e77d into master Apr 6, 2016
@bjacobel bjacobel deleted the fix-karma-hang branch April 6, 2016 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants