Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ Change Log

.. There should always be an "Unreleased" section for changes pending release.

[1.1.1] - 2020-10-27
~~~~~~~~~~~~~~~~~~~~

* Fix cache-checking in WaffleSwitchNamespace

[1.1.0] - 2020-10-23
~~~~~~~~~~~~~~~~~~~~

Expand Down
2 changes: 1 addition & 1 deletion edx_toggles/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
Library and utilities for feature toggles.
"""

__version__ = '1.1.0'
__version__ = '1.1.1'

default_app_config = 'edx_toggles.apps.TogglesConfig' # pylint: disable=invalid-name
5 changes: 5 additions & 0 deletions edx_toggles/tests/test_toggles.py
Original file line number Diff line number Diff line change
Expand Up @@ -97,3 +97,8 @@ def test_namespaced_switch_name(self):
expected = self.NAMESPACE_NAME + "." + self.WAFFLE_SWITCH_NAME
actual = self.WAFFLE_SWITCH.namespaced_switch_name
self.assertEqual(actual, expected)

def test_caching(self):
namespace = toggles.WaffleSwitchNamespace("namespace")
namespace.set_request_cache_with_short_name("switch1", True)
self.assertTrue(namespace.is_enabled("switch1"))
2 changes: 1 addition & 1 deletion edx_toggles/toggles/internal/waffle.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ def is_enabled(self, switch_name):
"""
Returns and caches whether the given waffle switch is enabled.
"""
value = self.get_request_cache(switch_name)
namespaced_switch_name = self._namespaced_name(switch_name)
value = self.get_request_cache(namespaced_switch_name)
if value is None:
value = switch_is_active(namespaced_switch_name)
self.set_request_cache(namespaced_switch_name, value)
Expand Down