[BD-21] Backport override_waffle_switch from edx-platform - #75
Merged
Conversation
|
Thanks for the pull request, @regisb! I've created BLENDED-641 to keep track of it in Jira. More details are on the BD-21 project page. When this pull request is ready, tag your edX technical lead. |
openedx-webhooks
added
blended
Contributor
Author
|
@robrap This is ready to review. |
11 tasks
robrap
reviewed
Oct 24, 2020
regisb
force-pushed
the
regisb/override-waffle
branch
3 times, most recently
from
October 26, 2020 10:29
e7bb308 to
b4b0b4d
Compare
This utility function is used in edx-platform, but also in edx/completion.
robrap
reviewed
Oct 26, 2020
This will be useful to replace the `override_for_request` method which was used in edx-platform.
regisb
force-pushed
the
regisb/override-waffle
branch
from
October 26, 2020 18:28
b4b0b4d to
a434244
Compare
Contributor
Author
|
I did exactly what I said I wouldn't and squashed my changes... Sorry about that @robrap! |
robrap
approved these changes
Oct 26, 2020
robrap
left a comment
robrap
left a comment
Contributor
There was a problem hiding this comment.
A combo of the conversation and these changes made this much simpler to review. Thank you!
regisb
commented
Oct 27, 2020
| """ | ||
| Returns and caches whether the given waffle switch is enabled. | ||
| """ | ||
| value = self.get_request_cache(switch_name) |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Backport
override_waffle_switchfrom edx-platform. This utility function is used in edx-platform, but also in edx/completion.JIRA: https://openedx.atlassian.net/wiki/spaces/COMM/pages/1596358943
Merge deadline: Before https://github.com/edx/edx-platform/pull/25417
Reviewers:
Merge checklist:
Post merge:
finished.