Re-enable content libraries runtime tests [FC-0062] #35783
Conversation
|
Thanks for the pull request, @pomegranited! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
openedx-webhooks
added
the
open-source-contribution
| @@ -169,8 +168,7 @@ def test_xblock_metadata(self): | |||
| """ | |||
| Test the XBlock metadata API | |||
| """ | |||
| unit_block_key = library_api.create_library_block(self.library.key, "unit", "metadata-u1").usage_key | |||
| problem_key = library_api.create_library_block_child(unit_block_key, "problem", "metadata-p1").usage_key | |||
There was a problem hiding this comment.
FYI: There's no create_library_block_child method in the api anymore -- and LearningCoreXBlockRuntime doesn't support child blocks, so I've removed parent-child relationships from these tests.
There was a problem hiding this comment.
LGTM 👍
Thank you for your work, @pomegranited!
- I checked the logs from
openedx-1-with-lmsandopenedx-1-with-cmsand confirmed that the tests ran - I read through the code
-
I checked for accessibility issuesN/A -
Includes documentationN/A
There was a problem hiding this comment.
@pomegranited Looks good, thank you!
- I tested this: (Ran tests locally as well as checked CI logs)
- I read through the code
-
I checked for accessibility issues -
Includes documentation
navinkarkera
deleted the
jill/kdmccormick/test-content-libraries-runtime
branch
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
) * test: run content_libraries runtime tests * test: fix broken tests * test: fix lms tests Co-authored-by: Kyle D. McCormick <[email protected]> (cherry picked from commit db587bd)
…35810) * test: run content_libraries runtime tests * test: fix broken tests * test: fix lms tests Co-authored-by: Kyle D. McCormick <[email protected]> (cherry picked from commit db587bd)
Description
Somewhere in the series of refactorings that this app has undergone, it seems that we removed TestCase from the inheritance tree of the tests in
openedx/core/djangoapps/content_libraries/tests/test_runtime.py, effectively skipping the test cases.This PR re-enables the tests and fixes what's broken since they were disabled.
Supporting information
Builds on/replaces: #35531
Private-ref: FAL-3927
Testing instructions
Check the logs of
openedx-1-with-lmsandopenedx-2-with-cmsto confirm that tests are run foropenedx/core/djangoapps/content_libraries/tests/test_runtime.py. Some will be skipped for the lms, some skipped for the cms, but all tests should be run by one or the other.Deadline
ASAP -- want to get into Sumac