Skip to content

Conversation

@jmbowman
Copy link
Contributor

@jmbowman jmbowman commented Jan 4, 2019

pytest-cov 2.5.1 isn't gathering coverage data correctly from remote pytest-xdist workers. Some fixes were made around this in 2.6.0, so try upgrading. This required making some tweaks to accommodate changes made in the new version:

Also pinned pillow since the new version is causing one test to fail for a reason I haven't had time to diagnose yet.

@jmbowman
Copy link
Contributor Author

jmbowman commented Jan 4, 2019

jenkins run pipeline python

@jmbowman
Copy link
Contributor Author

jmbowman commented Jan 7, 2019

jenkins run python

@jmbowman
Copy link
Contributor Author

jmbowman commented Jan 7, 2019

This doesn't seem to have fixed the problem with collecting coverage data from remote xdist workers, but does at least get us to the current release of pytest-cov so we can debug against the latest code.

@nedbat
Copy link
Contributor

nedbat commented Jan 7, 2019

What's going on now with the remote coverage files?

@jmbowman
Copy link
Contributor Author

jmbowman commented Jan 7, 2019

So the outstanding problem with the pipeline job for unit tests is that when using pytest-xdist with remote workers, pytest-cov is only reporting code coverage from test discovery on the main process; it's somehow failing to collect coverage data from the actual test execution on the remote workers. It works fine with multiple worker processes on the same machine, so it may be some sort of invalid assumption about working on a shared filesystem. I'm still digging through a few pytest-cov issues reported around this, as some people have gotten it working via fiddling with configuration options but aren't sure exactly how they did it.

This PR does at least fix coverage in our current build flow job with pytest 2.6.0. I also noticed just a little bit ago that 2.6.1 has been released, so I'll update the PR to use that and the also-just-released pytest 4.1.0.

@jmbowman jmbowman force-pushed the jmbowman/TE-2731 branch 2 times, most recently from 44d1695 to 0bb1aef Compare January 8, 2019 14:19
@edx-status-bot
Copy link

Your PR has finished running tests. There were no failures.

@jmbowman jmbowman merged commit f8dc051 into master Jan 8, 2019
@jmbowman jmbowman deleted the jmbowman/TE-2731 branch January 8, 2019 17:28
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Wednesday, January 09, 2019.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants