Updated requirements to ranges - #946
Conversation
4d73711 to
9c47847
Compare
|
This is necessary to support upgrading Django REST Framework for edx-platform. See https://github.com/edx/edx-platform/pull/13945. |
|
@cahrens @efischer19 please review |
c022991 to
8f6ad39
Compare
efischer19
left a comment
efischer19
left a comment
There was a problem hiding this comment.
Seems mostly fine to me, just a few questions about some removal changes.
|
|
||
| git+https://github.com/edx/django-pyfs.git@1.0.3#egg=django-pyfs==1.0.3 | ||
| git+https://github.com/edx/i18n-tools.git@56f048af9b6868613c14aeae760548834c495011#egg=i18n_tools | ||
| git+https://github.com/edx/edx-lint.git@v0.4.1#egg=edx_lint==0.4.1 |
There was a problem hiding this comment.
Why were these 2 removed? I know edx/i18n-tools is needed for translation updates at least. It probably should be updated to a more recent version like v0.3.4, and may not be in the right location, but removing it entirely seems like a problem. edx-lint I'm less concerned about.
There was a problem hiding this comment.
Both of these are hosted on PyPI. I added them to the list above.
There was a problem hiding this comment.
Ah, I had missed that initially. Great!
| branches: | ||
| only: | ||
| - master | ||
| - ora-staff-grading |
There was a problem hiding this comment.
For my own edification - what's the impact of this change? Just that Travis builds will run more regularly on non-master branches?
There was a problem hiding this comment.
| setup( | ||
| name='ora2', | ||
| version='1.1.10', | ||
| version='1.1.11', |
There was a problem hiding this comment.
Please leave this at the current version for this PR, and I'll take care of updating it with translations as part of the ORA release process. @cahrens, do you or your team have any work you'd like to release soon, or should I get this process started once this PR lands?
There was a problem hiding this comment.
@efischer19 go ahead and start the release process-- I did merge something on Friday, so I will have something to verify.
|
@clintonb Did you verify that the a11y and acceptance tests pass with these changes? Note that you will have to create a sandbox and run them manually, since they don't run as part of the travis build. |
8f6ad39 to
759accd
Compare
|
@cahrens I have not run those tests. Time permitting, I'll run them today and post back here. |
|
Have you given any thought to integrating those tests here into this repo? |
| mock>=1.0.1,<2.0.0 | ||
| moto>=0.3.1,<1.0.0 | ||
| pep8>=1.7.0,<2.0.0 | ||
| factory_boy>=2.6.1,3.0.0 |
759accd to
3db29d9
Compare
|
@clintonb The integration/a11y tests are in this repo. They just run through Jenkins jobs on master, instead of as part of the travis build. See https://openedx.atlassian.net/wiki/display/TNL/ORA+FAQ#ORAFAQ-Runningacceptancetests |
If we are going to read setup.py requirements from files, the files need to use ranges. Otherwise, we will end up with requirement conflicts when the main project wants to upgrade requirements.
761400f to
413de84
Compare
|
Implemented in #1023, containing the latest DRF updates as certified by the Platform team |
3 participants
If we are going to read setup.py requirements from files, the files need to use ranges. Otherwise, we will end up with requirement conflicts when the main project wants to upgrade requirements.