revert: rollback changes from #2171 and #2181 - #2184
Conversation
|
Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2184 +/- ##
==========================================
- Coverage 95.04% 95.03% -0.01%
==========================================
Files 191 191
Lines 21035 21003 -32
Branches 1899 1896 -3
==========================================
- Hits 19992 19960 -32
Misses 779 779
Partials 264 264
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I think we should wait for the discussion here before merging this. |
pomegranited
left a comment
There was a problem hiding this comment.
👍 Thank you for reverting this change @rpenido !
Could you please resolve the conflicts and bump the version again?
- I tested this while testing openedx/openedx-platform#34270
- I read through the code
-
I checked for accessibility issuesN/A -
Includes documentationN/A -
User-facing strings are extracted for translationN/A
|
This is ready for review/merge @pomegranited! |
|
I re-tested openedx/openedx-platform#34270 with this revert, and it's all working fine. |
|
@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
We refactored the way we store content tag data while exporting the XBlock and some previous changes are not needed anymore. This reverts the following PRs:
More information
Depends on:
Testing instructions
Private ref: FAL-3621