Skip to content

revert: rollback changes from #2171 and #2181 - #2184

Merged
pomegranited merged 5 commits into
openedx:masterfrom
open-craft:rpenido/fal-3621-revert-tag-serialize-and-deserialize-changes
Mar 7, 2024
Merged

revert: rollback changes from #2171 and #2181#2184
pomegranited merged 5 commits into
openedx:masterfrom
open-craft:rpenido/fal-3621-revert-tag-serialize-and-deserialize-changes

Conversation

@rpenido

@rpenido rpenido commented Mar 1, 2024

Copy link
Copy Markdown
Contributor

Description

We refactored the way we store content tag data while exporting the XBlock and some previous changes are not needed anymore. This reverts the following PRs:

More information

Depends on:

Testing instructions

  • Make sure the tests cover the various cases.

Private ref: FAL-3621

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 1, 2024
@openedx-webhooks

openedx-webhooks commented Mar 1, 2024

Copy link
Copy Markdown

Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@codecov

codecov Bot commented Mar 1, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.03%. Comparing base (2e8ed09) to head (8dffff1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2184      +/-   ##
==========================================
- Coverage   95.04%   95.03%   -0.01%     
==========================================
  Files         191      191              
  Lines       21035    21003      -32     
  Branches     1899     1896       -3     
==========================================
- Hits        19992    19960      -32     
  Misses        779      779              
  Partials      264      264              
Flag Coverage Δ
unittests 95.03% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rpenido
rpenido marked this pull request as ready for review March 1, 2024 19:17
@rpenido
rpenido requested review from a team and pomegranited March 1, 2024 19:17
@rpenido
rpenido marked this pull request as draft March 4, 2024 21:55
@rpenido

rpenido commented Mar 4, 2024

Copy link
Copy Markdown
Contributor Author

I think we should wait for the discussion here before merging this.

@pomegranited pomegranited left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you for reverting this change @rpenido !

Could you please resolve the conflicts and bump the version again?

  • I tested this while testing openedx/openedx-platform#34270
  • I read through the code
  • I checked for accessibility issues N/A
  • Includes documentation N/A
  • User-facing strings are extracted for translation N/A

Comment thread openassessment/__init__.py Outdated
@rpenido
rpenido marked this pull request as ready for review March 6, 2024 13:28
@rpenido

rpenido commented Mar 6, 2024

Copy link
Copy Markdown
Contributor Author

This is ready for review/merge @pomegranited!

@pomegranited

Copy link
Copy Markdown
Contributor

I re-tested openedx/openedx-platform#34270 with this revert, and it's all working fine.

@pomegranited
pomegranited merged commit 8de0eaf into openedx:master Mar 7, 2024
@openedx-webhooks

Copy link
Copy Markdown

@rpenido 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants