[DRAFT] webpack update - #1512
Merged
Merged
Conversation
muselesscreator
force-pushed
the
webpack
branch
from
October 1, 2020 20:03
179745b to
a82913b
Compare
muselesscreator
requested review from
Andytr1,
jansenk,
jnlapierre,
mattcarter and
nsprenkle
October 1, 2020 20:56
3 tasks
jansenk
reviewed
Oct 14, 2020
jansenk
left a comment
jansenk
left a comment
Contributor
There was a problem hiding this comment.
I've read through the changes and I have no concerns
| // start these browsers | ||
| // available browser launchers: https://npmjs.org/browse/keyword/karma-launcher | ||
| browsers: ['PhantomJS'], | ||
| browsers: ['HeadlessChrome'], |
Contributor
Author
There was a problem hiding this comment.
clearing warnings. PhantomJS not supported any more if I recall
muselesscreator
force-pushed
the
webpack
branch
2 times, most recently
from
October 19, 2020 20:54
c9a1309 to
59f5766
Compare
nsprenkle
reviewed
Oct 20, 2020
nsprenkle
left a comment
nsprenkle
left a comment
Contributor
There was a problem hiding this comment.
Overall looks good, pending continued successful smoke test and removal of console.logs. Random questions and comments (largely for my own curiosity) peppered throughout.
added 18 commits
October 22, 2020 15:58
muselesscreator
force-pushed
the
webpack
branch
from
October 22, 2020 19:59
146f558 to
5564a5e
Compare
8 tasks
jansenk
added a commit
that referenced
this pull request
Mar 7, 2022
fix: restore original tinymce behavior, fix trailing slash In PR #1512 we introduced the bug by improperly combining the "dataHandler" methods into one method and only setting/checking src rather than also including href In PR #1794 we attempted to fix the issue by fixing the order of the to->from in the dataHandler. We also did a more specific replacement of <a href=<url> and <img src=<url> This fixed the issue of inserting bad links and images, but the static url const used in the "load all content" transform was missing a slash resulting in incorrect "resolved" URLs. Thankfully according to the read replica, there are only 3 of those that currently exist. Removing the handlers for EditImage and EditLink. Originally their purpose was so that you would only ever see the "static" link. When the image/link was saved, we'd convert it from the static link to the real link, and then when you would click "edit" we'd transition back from the real link to the "static" link. I'm getting rid of that. The URL presented in the edit dialog should actually be the URL and having it go back and forth hides the actual real value of the URL. Unnecessary and potentially confusing. Removing the specific <a href=<url> and <img src=<url> filtering for the full content transform. It's nice, and it will potentially prevent issues where we have a /static/ that we don't want transformed, but unfortunately having the global replace is the current only way we can support resolving static URLs in audio or video embeds. (see https://openedx.atlassian.net/browse/AU-544) Rather than adding those specific "special cases" it seems like it's probably just easier to do the more general resolve?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR -
Update our build process for ORA2 JS to use webpack, thus allowing use of ES6 tools/syntax.
Uses frontend-build in order to closely align with MFE build practices.
What changed?
o.0
no more requireJS imports.
All JS is imported/exported from files.
npm configuration files for webpack builds based on frontend-build.
webpack build commands in Makefile.
ESlint styling changes, where feasible/easy/automatic.
Note: There are a number of remaining issues that are currently ignored by disabling rules in the eslint config that ABSOLUTELY should be addressed in the future (especially number of classes exported from a given file).
Developer Checklist
JIRA: JIRA-5190
FIY: @edx/masters-devs-gta