feat: handlers for taxonomy xblock openedx-events - #3710
Conversation
|
Thanks for the pull request, @navinkarkera! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
|
@ansabgillani could you please take a look and allow tests to run? |
tecoholic
left a comment
There was a problem hiding this comment.
@navinkarkera While the code is straightforward, I am wondering about the necessity of this new handler. This feels like a glue code that does the following:
even handler event handler
|---------------| signal +-------------------+ signal +--------------------+
|openedx-events |----------->| Course Discovery | --------->| taxonomy connector |
|---------------| +-------------------+ +--------------------+
Is there a reason why we cannot simply add openedx-events directly as a dependency to the taxonomy connector and achieve something like this?
event handler
|---------------| signal +--------------------+
|openedx-events |------------| taxonomy connector |
|---------------| +--------------------+
@tecoholic Like I mentioned in openedx/taxonomy-connector#127 (comment), |
Implements handlers to catch openedx-events related to xblocks like deletion, duplication and publish. Currently these handlers just trigger related signals provided by taxonomy-connectors which do the leg work of updating xblock skills.
e89739a to
ef68e4d
Compare
|
Closing as the signals are now directly handled in openedx/taxonomy-connector#127 |
|
@navinkarkera Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
Implements handlers to catch openedx-events related to xblocks like deletion, duplication and publish. Currently these handlers just trigger related signals provided by taxonomy-connectors which do the leg work of updating xblock skills.
Private-ref: BB-6931Dependencies:
Merge checklist