feature: Allow installing extra requirements when using the credentials role - #6449
Conversation
|
Thanks for the pull request, @kewne! I've created OSPR-5867 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
|
@kewne Thank you for your contribution. Please let me know once it is ready for our review. |
fc15d1f to
5775df3
Compare
lgp171188
left a comment
There was a problem hiding this comment.
@kewne, 👍. Before the edX/core committer review, can you edit the description of this PR to mention that this is going to be used to install a theme in the credentials service as documented here?
- I tested this change and verified that it works as expected. It is similar to the changes done in https://github.com/edx/configuration/pull/6400
- I read through the code
-
I checked for accessibility issuesNA -
Includes documentationNA
|
@natabene, this is now ready for edX/core committer review. The workflows configured for PRs in this repository haven't run for this PR, and there is a message that says @pomegranited, will you be able to review this PR as a core committer since you reviewed the very similar https://github.com/edx/configuration/pull/6400? Thanks! |
Done, thanks! |
|
👍 Works perfectly, thank you @kewne !
I'll merge this in 2 days if there are no objections from @edx/devops . |
|
@pomegranited oops! I can amend this to match the expected format, it's not too much trouble. |
|
Sure if you want to @kewne :) |
…` role. This makes the `credentials` role support the use of `edx_django_service_extra_requirements` as done originally in [!6400](https://github.com/edx/configuration/pull/6400) Related tickets: * [BB-4342](https://tasks.opencraft.com/browse/BB-4342)
5775df3 to
e2afa0d
Compare
pomegranited
left a comment
There was a problem hiding this comment.
Approved, see previous comment 👍
|
@kewne 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This makes the
credentialsrole support the use ofedx_django_service_extra_requirementsas done originally in !6400
The end-goal of this is to support theming of the credentials service as described here
Related tickets:
Testing
make dev.up.credentialsconfigurationrepo, create adocker_inventory.inifile containing justcredentials_test.yml:playbooksdirectory (to ensure ansible.cfg is picked up):ansible-playbook credentials_test.yml -i docker_inventory.ini --skip-tags install:code -e '{ disable_edx_services: true, CREDENTIALS_EXTRA_REQUIREMENTS: [{name: 'lolcat'}], edx_django_service_is_devstack: true}'lolcatis now installed in the credentials virtualenv: