This repository was archived by the owner on Aug 3, 2026. It is now read-only.
feature: Allow installing extra requirements when using the credentials role - #169
Merged
kewne merged 1 commit intoJun 25, 2021
Conversation
…als` role. This makes the `credentials` role support the use of `edx_django_service_extra_requirements` as done originally in [!6400](https://github.com/edx/configuration/pull/6400) Related tickets: * [BB-4342](https://tasks.opencraft.com/browse/BB-4342)
lgp171188
approved these changes
Jun 25, 2021
lgp171188
left a comment
There was a problem hiding this comment.
👍
- I did not test this, as it is a straightforward change that is similar to the changes done before for the
ecommerceandcourse-discoveryservices. - I read through the code
-
I checked for accessibility issuesNA -
Includes documentationNA
|
@kewne Could you update this PR description to link to your upstream PR? Helps us during major version updates to track what's "code drift" vs what's been merged upstream. |
Author
|
@pomegranited Done, thanks for the nudge. |
samuelallan72
pushed a commit
that referenced
this pull request
Oct 11, 2021
…ls_extra_requirements_koa feature: Allow installing extra requirements when using the `credentials` role (cherry picked from commit 7ce36c7)
3 tasks
samuelallan72
pushed a commit
that referenced
this pull request
Oct 19, 2021
…ls_extra_requirements_koa feature: Allow installing extra requirements when using the `credentials` role (cherry picked from commit 7ce36c7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the
credentialsrole support the use ofedx_django_service_extra_requirementsas done originally in !6400
The changes here are cherry-picked from the upstream work in https://github.com/edx/configuration/pull/6449
Related links:
Testing
make dev.up.credentialsconfigurationrepo, create adocker_inventory.inifile containing justcredentials_test.yml:playbooksdirectory (to ensure ansible.cfg is picked up):ansible-playbook credentials_test.yml -i docker_inventory.ini --skip-tags install:code -e '{ disable_edx_services: true, CREDENTIALS_EXTRA_REQUIREMENTS: [{name: 'lolcat'}], edx_django_service_is_devstack: true}'lolcatis now installed in the credentials virtualenv: