fix: StudioContainerXBlockMixin needs to be updated to match edx-platform changes [BD-13] - #200
Conversation
openedx-webhooks
added
the
blended
|
Thanks for the pull request, @bradenmacdonald! When this pull request is ready, tag your edX technical lead. |
|
|
||
| class StudioContainerXBlockMixin: | ||
| @XBlock.needs('mako') | ||
| class StudioContainerXBlockMixin(XBlockMixin): |
There was a problem hiding this comment.
@bradenmacdonald, it's very similar to the StudioEditableBlock. Would it make sense to merge them?
There was a problem hiding this comment.
Yes. I think the author_edit_view/author_preview_view functionality is unique, but we could probably make this one so that it subclasses StudioEditableBlock and then we could remove the render_children from this one. Is that what you're thinking?
There was a problem hiding this comment.
@bradenmacdonald, I think that the StudioEditableBlock needs to be a subclass of the StudioContainerXBlockMixin. We cannot add an edx-platform import to the xblock-utils, because this library is used by the workbench.
There was a problem hiding this comment.
I see. So then this PR has to come first. I got the tests passing now so @Agrendalath can you please give it another look?
88f834c to
4480a36
Compare
Agrendalath
left a comment
Agrendalath
left a comment
There was a problem hiding this comment.
👍
- I tested this: checked that the
ProblemBuilderworks correctly in Studio - I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: n/a
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository: n/a
| """ | ||
|
|
||
| __version__ = '3.0.0' | ||
| __version__ = '3.0.1' |
There was a problem hiding this comment.
This version breaks Maple compatibility because MakoService was introduced in Nutmeg. While Maple is an old release, it's good to bump the minor version and add a fix! to announce this. I did a similar thing in openedx/xblock-drag-and-drop-v2#318.
There was a problem hiding this comment.
Sure, doing that now. Thanks!
|
@bradenmacdonald, while testing this, I found a small bug in the Problem Builder when the Block Structures are generated. Would you like to take a quick look at open-craft/problem-builder#349? |
4480a36 to
323e588
Compare
|
@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
@bradenmacdonald @Agrendalath Thanks for this fix. FYI my problem-builders are still showing the same error in edx.org, both existing problem-builders and new ones I create. Does this mean there is still something to resolve here? |
|
@jswope00, the requirements upgrade PR openedx/openedx-platform#32321 (which includes this change) is not merged, so this still needs to be deployed to edx.org. |
|
Perfect @Agrendalath thanks for that. Again, appreciate this fix. |
4 participants
The Problem Builder XBlock has not been working in master versions of edx-platform, after openedx/openedx-platform@248c090 was merged via openedx/openedx-platform#31472 .
Without this fix:
With this fix:
This bug was reported at https://discuss.openedx.org/t/reporting-supporting-a-fix-for-problem-builder-x-block-issue/10114/2
Private ref: MNG-3708