This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Enrollment table #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| columns: ['date', 'count'], | ||
| sorting: ['-date'], | ||
| data: jsonData.enrollmentTrends | ||
| }).render(); |
There was a problem hiding this comment.
Minor: Have the other views above use the same pattern
new TrendView({
model: model,
el: '#enrollment-trend-view'
}).render();
There was a problem hiding this comment.
I'll take care of this in the geolocation PR.
|
A few minor style issues. Let me know if they make sense or not to you before giving thumbs up. |
|
@rocha I'll make all the style changes in the geolocation PR, which should be ready within the hour. |
|
🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a table with enrollment values. It is built atop the enrollment-acceptance-tests branch, so review #6 first.