Skip to content
This repository was archived by the owner on May 6, 2024. It is now read-only.

Revert "temp: Add Atlas pull_translations back in, but with debug logging" - #7125

Merged
timmc-edx merged 1 commit into
masterfrom
revert-7122-timmc/atlas-logging
Feb 26, 2024
Merged

Revert "temp: Add Atlas pull_translations back in, but with debug logging"#7125
timmc-edx merged 1 commit into
masterfrom
revert-7122-timmc/atlas-logging

Conversation

@timmc-edx

Copy link
Copy Markdown

Reverts #7122 -- the final compilejs step was producing the following npm-ci error:

npm ERR! While resolving: karma-selenium-webdriver-launcher@0.0.4
npm ERR! Found: selenium-webdriver@3.4.0
npm ERR! node_modules/selenium-webdriver
npm ERR!   dev selenium-webdriver@"3.4.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer selenium-webdriver@"^2.44.0" from karma-selenium-webdriver-launcher@0.0.4
npm ERR! node_modules/karma-selenium-webdriver-launcher
npm ERR!   dev karma-selenium-webdriver-launcher@"0.0.4" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: selenium-webdriver@2.53.3
npm ERR! node_modules/selenium-webdriver
npm ERR!   peer selenium-webdriver@"^2.44.0" from karma-selenium-webdriver-launcher@0.0.4
npm ERR!   node_modules/karma-selenium-webdriver-launcher
npm ERR!     dev karma-selenium-webdriver-launcher@"0.0.4" from the root project

@robrap robrap left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is compilejs called, and can you make translations work for non-js files first, and resolve the rest later?

@timmc-edx

Copy link
Copy Markdown
Author

compilejs is called at the end of the pull_translations make recipe, after the Atlas-specific bits: https://github.com/openedx/edx-platform/blob/22ada3b939502c837b2e454c7f8c61fb835c5ca5/Makefile#L89

I can't readily separate it out. (Also, I don't know enough about what all of these commands are doing and how they related to each other.)

@timmc-edx
timmc-edx merged commit 70eb142 into master Feb 26, 2024
@timmc-edx
timmc-edx deleted the revert-7122-timmc/atlas-logging branch February 26, 2024 17:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants