Skip to content
This repository was archived by the owner on May 6, 2024. It is now read-only.

refactor: add CELERY_RESULT_BACKEND with default django-cache - #6772

Merged
NIXKnight merged 1 commit into
openedx-unsupported:open-release/nutmeg.masterfrom
open-craft:navin/set-celery-result-backend-nutmeg
Jul 14, 2022
Merged

refactor: add CELERY_RESULT_BACKEND with default django-cache#6772
NIXKnight merged 1 commit into
openedx-unsupported:open-release/nutmeg.masterfrom
open-craft:navin/set-celery-result-backend-nutmeg

Conversation

@navinkarkera

Copy link
Copy Markdown
Contributor

Description

Cherry pick of openedx/openedx-platform#30244

At Opencraft, we want to run multiple instances of celery workers in separate servers. The celery workers need to be able to share task results. Currently, the CELERY_RESULT_BACKEND is hard coded to use django-cache.

So this PR allows to setup CELERY_RESULT_BACKEND via configuration.

To use django ORM as celery backend, one can set CELERY_RESULT_BACKEND to django-db as described in docs.

Supporting information

Deadline

"None"

@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @navinkarkera! I've created OSPR-6788 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Jun 13, 2022
@natabene

Copy link
Copy Markdown
Contributor

@navinkarkera Thank you for your contribution, is this ready for our review?

@navinkarkera

Copy link
Copy Markdown
Contributor Author

@natabene Thank you! Yes it s ready for your review.
cc: @kaustavb12

@kaustavb12 kaustavb12 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Looks good to go from my end.

  • I tested this: I tested the configuration in the PR sandbox
  • I read through the code
  • Includes documentation

@adzuci

adzuci commented Jul 13, 2022

Copy link
Copy Markdown
Contributor

@navinkarkera Would you mind rebasing this PR?

@navinkarkera

Copy link
Copy Markdown
Contributor Author

@navinkarkera Would you mind rebasing this PR?

@adzuci It is already up to date with nutmeg branch.

@NIXKnight NIXKnight left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@NIXKnight
NIXKnight merged commit 6e77545 into openedx-unsupported:open-release/nutmeg.master Jul 14, 2022
@openedx-webhooks

Copy link
Copy Markdown

@navinkarkera 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants