Skip to content
This repository was archived by the owner on May 6, 2024. It is now read-only.

fix: add CELERY_RESULT_BACKEND with default django-cache - #6721

Merged
jfavellar90 merged 2 commits into
openedx-unsupported:open-release/lilac.masterfrom
open-craft:navin/set-celery-result-backend-lilac
Jul 28, 2022
Merged

fix: add CELERY_RESULT_BACKEND with default django-cache#6721
jfavellar90 merged 2 commits into
openedx-unsupported:open-release/lilac.masterfrom
open-craft:navin/set-celery-result-backend-lilac

Conversation

@navinkarkera

Copy link
Copy Markdown
Contributor

Configuration Pull Request

Cherry pick of #6720

Note: This PR has a corresponding edx-platform PR openedx/openedx-platform#30245

Description

At Opencraft, we want to run multiple instances of celery workers in separate servers. The celery workers need to be able to share task results. Currently, the CELERY_RESULT_BACKEND is hard coded to use django-cache.

So this PR allows to setup CELERY_RESULT_BACKEND via configuration.

To use django ORM as celery backend, one can set CELERY_RESULT_BACKEND to django-db as described in docs.

Supporting information

Deadline

"None"

@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @navinkarkera! I've created OSPR-6622 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Apr 14, 2022
@natabene

Copy link
Copy Markdown
Contributor

@navinkarkera Thank you for the contribution. Is this ready for our review?

@openedx-webhooks openedx-webhooks added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs triage labels Apr 26, 2022
@kaustavb12

Copy link
Copy Markdown
Contributor

Hi @natabene !

This is not ready for your review yet. I'll ping you here once ready.

@natabene

Copy link
Copy Markdown
Contributor

@navinkarkera Just checking if this is ready.

@kaustavb12

Copy link
Copy Markdown
Contributor

@natabene We have scheduled to review and test this internally in the ongoing sprint. Will ping here once ready. Perhaps early next week.

@kaustavb12

Copy link
Copy Markdown
Contributor

👍

Looks good to go from my end.

  • I tested this: Changes tested in the PR sandbox
  • I read through the code
  • Includes documentation

@navinkarkera

Copy link
Copy Markdown
Contributor Author

@natabene This is ready for your review.

@natabene

Copy link
Copy Markdown
Contributor

@navinkarkera Thanks, I am lining this up for our review.

@natabene

Copy link
Copy Markdown
Contributor

@BbrSofiane This is ready for your review.

@OmarIthawi

Copy link
Copy Markdown
Contributor

@navinkarkera This is on lilac but the other PR is on nutmeg did I miss anything?

@navinkarkera

Copy link
Copy Markdown
Contributor Author

@navinkarkera This is on lilac but the other PR is on nutmeg did I miss anything?

@OmarIthawi We also have one for lilac

@jfavellar90
jfavellar90 merged commit d819c88 into openedx-unsupported:open-release/lilac.master Jul 28, 2022
@openedx-webhooks

Copy link
Copy Markdown

@navinkarkera 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@openedx-webhooks openedx-webhooks removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants