Skip to content
This repository was archived by the owner on May 6, 2024. It is now read-only.

Unindent a few entries that needd to be unindented - #6450

Merged
christopappas merged 1 commit into
masterfrom
cpappas/fix-ansible-issue
Jun 17, 2021
Merged

Unindent a few entries that needd to be unindented#6450
christopappas merged 1 commit into
masterfrom
cpappas/fix-ansible-issue

Conversation

@christopappas

@christopappas christopappas commented Jun 17, 2021

Copy link
Copy Markdown
Contributor

Configuration Pull Request

Make sure that the following steps are done before merging:

  • A DevOps team member has approved the PR if it is code shared across multiple services and you don't own all of the services.
  • Are you adding any new default values that need to be overridden when this change goes live? If so:
    • Update the appropriate internal repo (be sure to update for all our environments)
    • If you are updating a secure value rather than an internal one, file a DEVOPS ticket with details.
    • Add an entry to the CHANGELOG.
  • If you are making a complicated change, have you performed the proper testing specified on the Ops Ansible Testing Checklist? Adding a new variable does not require the full list (although testing on a sandbox is a great idea to ensure it links with your downstream code changes).
  • Think about how this change will affect Open edX operators. Have you updated the wiki page for the next Open edX release?

@christopappas
christopappas merged commit 945fe9d into master Jun 17, 2021
@christopappas
christopappas deleted the cpappas/fix-ansible-issue branch June 17, 2021 20:30
@regisb regisb mentioned this pull request Jul 4, 2021
Merged
2 tasks
BbrSofiane pushed a commit to BbrSofiane/configuration that referenced this pull request Jul 4, 2021
@christopappas @BbrSofiane
Unindent a few entries that needd to be unindented (openedx-unsupport…
81a14bc 
…ed#6450)

(cherry picked from commit 945fe9d)
pomegranited pushed a commit that referenced this pull request Jul 6, 2021
@BbrSofiane @christopappas
Unindent a few entries that needd to be unindented (#6450) (#6467)
8e2c77b 
(cherry picked from commit 945fe9d)

Co-authored-by: Chris Pappas <christopappas@users.noreply.github.com>
gabor-boros pushed a commit to open-craft/configuration that referenced this pull request Jul 7, 2021
@BbrSofiane @christopappas @gabor-boros
Unindent a few entries that needd to be unindented (openedx-unsupport…
ae2328e 
…ed#6450) (openedx-unsupported#6467)

(cherry picked from commit 945fe9d)

Co-authored-by: Chris Pappas <christopappas@users.noreply.github.com>
@itsjeyd itsjeyd mentioned this pull request Jul 7, 2021
Merged
1 task
gabor-boros added a commit to open-craft/configuration that referenced this pull request Jul 12, 2021
@gabor-boros @christopappas
feat: add celerybeat configuration
561ad79 
The current implementation of celerybeat usage works properly if and
only if one concurrent worker process runs per queue using the nested
beat process started by the `--beat` flag. In case the the celerybeat
process is running as a separate process not as part of the workers,
that partially solves the problem. Either in that case, if multiple
instances are running in a cluster, without proper process supervising
across instances will result in (at least) dumplicated scheduling,
meaning that the scheduler will cause more work for the workers and
results will be duplicated.

Taking the above into consideration, to solve this issue, this commit
introduces single-beat package that wraps the celerybeat process and
keeps track of the process that acquired the lock in redis. In case one
of the instances get killed or the locking process crashes, the lock

refactor: use boolean flag to enable or disable celery beat
Co-authored-by: Joseph Mulloy <jdmulloy@users.noreply.github.com>

refactor: use boolean flag to enable or disable celery beat
Co-authored-by: Joseph Mulloy <jdmulloy@users.noreply.github.com>

Unindent a few entries that needd to be unindented (openedx-unsupported#6450) (openedx-unsupported#6467)
(cherry picked from commit 945fe9d)
Co-authored-by: Chris Pappas <christopappas@users.noreply.github.com>
gabor-boros added a commit to open-craft/configuration that referenced this pull request Jul 12, 2021
@gabor-boros @christopappas
feat: add celerybeat configuration
5c0c186 
The current implementation of celerybeat usage works properly if and
only if one concurrent worker process runs per queue using the nested
beat process started by the `--beat` flag. In case the the celerybeat
process is running as a separate process not as part of the workers,
that partially solves the problem. Either in that case, if multiple
instances are running in a cluster, without proper process supervising
across instances will result in (at least) dumplicated scheduling,
meaning that the scheduler will cause more work for the workers and
results will be duplicated.

Taking the above into consideration, to solve this issue, this commit
introduces single-beat package that wraps the celerybeat process and
keeps track of the process that acquired the lock in redis. In case one
of the instances get killed or the locking process crashes, the lock

refactor: use boolean flag to enable or disable celery beat
Co-authored-by: Joseph Mulloy <jdmulloy@users.noreply.github.com>

refactor: use boolean flag to enable or disable celery beat
Co-authored-by: Joseph Mulloy <jdmulloy@users.noreply.github.com>

Unindent a few entries that needd to be unindented (openedx-unsupported#6450) (openedx-unsupported#6467)
(cherry picked from commit 945fe9d)
Co-authored-by: Chris Pappas <christopappas@users.noreply.github.com>
This was referenced Jul 12, 2021
Merged
Merged
jdmulloy pushed a commit that referenced this pull request Jul 15, 2021
@gabor-boros @christopappas @jdmulloy
feat: add celerybeat configuration
8ebc62c 
The current implementation of celerybeat usage works properly if and
only if one concurrent worker process runs per queue using the nested
beat process started by the `--beat` flag. In case the the celerybeat
process is running as a separate process not as part of the workers,
that partially solves the problem. Either in that case, if multiple
instances are running in a cluster, without proper process supervising
across instances will result in (at least) dumplicated scheduling,
meaning that the scheduler will cause more work for the workers and
results will be duplicated.

Taking the above into consideration, to solve this issue, this commit
introduces single-beat package that wraps the celerybeat process and
keeps track of the process that acquired the lock in redis. In case one
of the instances get killed or the locking process crashes, the lock

refactor: use boolean flag to enable or disable celery beat
Co-authored-by: Joseph Mulloy <jdmulloy@users.noreply.github.com>

refactor: use boolean flag to enable or disable celery beat
Co-authored-by: Joseph Mulloy <jdmulloy@users.noreply.github.com>

Unindent a few entries that needd to be unindented (#6450) (#6467)
(cherry picked from commit 945fe9d)
Co-authored-by: Chris Pappas <christopappas@users.noreply.github.com>
gabor-boros added a commit to edx-olive/configuration-old that referenced this pull request Oct 11, 2021
@gabor-boros @christopappas
feat: add celerybeat configuration
479987e 
The current implementation of celerybeat usage works properly if and
only if one concurrent worker process runs per queue using the nested
beat process started by the `--beat` flag. In case the the celerybeat
process is running as a separate process not as part of the workers,
that partially solves the problem. Either in that case, if multiple
instances are running in a cluster, without proper process supervising
across instances will result in (at least) dumplicated scheduling,
meaning that the scheduler will cause more work for the workers and
results will be duplicated.

Taking the above into consideration, to solve this issue, this commit
introduces single-beat package that wraps the celerybeat process and
keeps track of the process that acquired the lock in redis. In case one
of the instances get killed or the locking process crashes, the lock

refactor: use boolean flag to enable or disable celery beat
Co-authored-by: Joseph Mulloy <jdmulloy@users.noreply.github.com>

refactor: use boolean flag to enable or disable celery beat
Co-authored-by: Joseph Mulloy <jdmulloy@users.noreply.github.com>

Unindent a few entries that needd to be unindented (openedx-unsupported#6450) (openedx-unsupported#6467)
(cherry picked from commit 945fe9d)
Co-authored-by: Chris Pappas <christopappas@users.noreply.github.com>
johanseto pushed a commit to eduNEXT/configuration that referenced this pull request Mar 18, 2022
@gabor-boros @christopappas @johanseto
feat: add celerybeat configuration
ce7167e 
The current implementation of celerybeat usage works properly if and
only if one concurrent worker process runs per queue using the nested
beat process started by the `--beat` flag. In case the the celerybeat
process is running as a separate process not as part of the workers,
that partially solves the problem. Either in that case, if multiple
instances are running in a cluster, without proper process supervising
across instances will result in (at least) dumplicated scheduling,
meaning that the scheduler will cause more work for the workers and
results will be duplicated.

Taking the above into consideration, to solve this issue, this commit
introduces single-beat package that wraps the celerybeat process and
keeps track of the process that acquired the lock in redis. In case one
of the instances get killed or the locking process crashes, the lock

refactor: use boolean flag to enable or disable celery beat
Co-authored-by: Joseph Mulloy <jdmulloy@users.noreply.github.com>

refactor: use boolean flag to enable or disable celery beat
Co-authored-by: Joseph Mulloy <jdmulloy@users.noreply.github.com>

Unindent a few entries that needd to be unindented (openedx-unsupported#6450) (openedx-unsupported#6467)
(cherry picked from commit 945fe9d)
Co-authored-by: Chris Pappas <christopappas@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@jdmulloy jdmulloy jdmulloy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@christopappas @jdmulloy