Switch to Github Actions and remove constraints on the cryptography and mysqlclient packages. - #124
Conversation
|
Thanks for the pull request, @symbolist! I've created OSPR-6028 to keep track of it in JIRA. As a core committer in this repo, you can merge this once the pull request is approved per the core committer reviewer requirements and according to the agreement with your edX Champion. |
9706d1a to
7f36971
Compare
|
@symbolist Thank you for your contribution. @bradenmacdonald Would you like to review this? |
|
@natabene Yes, I'd be happy to review this. |
|
@bradenmacdonald Thank you! |
|
@symbolist I see this is green but still marked as a draft; let me know when it's ready for review. |
7f36971 to
766f38f
Compare
766f38f to
3fd8022
Compare
|
@bradenmacdonald It is ready for review now! |
| ENV VIRTUAL_ENV=/blockstore/venv | ||
|
|
||
| RUN apt-get update | ||
| RUN apt-get install libmysqlclient-dev libjpeg-dev libssl-dev libffi-dev python3 python3-venv python3-pip git -y |
There was a problem hiding this comment.
libssl-dev and libffi-dev were required by the cryptography package but according to the docs, with the latest version of pip, a binary wheel is installed so those are no longer needed.
bradenmacdonald
left a comment
There was a problem hiding this comment.
👍 please merge at your convenience.
- I tested this: Ran
make dev.buildandmake easyserver, confirmed GitHub build is green - I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: n/a
|
@ormsbee Any chance you would help us with this CircleCI request? |
|
Just disabled the build in CircleCI settings. Going to close and re-open this. fyi @natabene @symbolist |
|
Hello @symbolist: We are unable to continue with review of your submission at this time. Please see the associated JIRA ticket for more explanation. |
|
@pomegranited Is this helpful? |
|
Hm, that may not have worked. I'm on a phone right now -- I can take another look in an hour when I'm on a laptop. |
|
@kdmccormick Thanks for much for looking into this. |
3fd8022 to
4229a01
Compare
|
@symbolist I amended your most recent commit (with no changes) and force-pushed. Let's see if that works. |
|
Great, there we go. I think the branch's head commit hash needed to be changed in order to get rid of the CircleCI status. @natabene @symbolist @pomegranited @bradenmacdonald This PR should be good to move forward now. |
3fd8022 to
4229a01
Compare
|
@ormsbee, @kdmccormick: thought you might like to know that symbolist merged this pull request. |
|
@kdmccormick Thanks, that worked! |
Description
We have a constraint on the
cryptographypackage because the CircleCI tests usealpinedocker image on which a Rust dependency is unavailable.To be able to install blockstore as a package in edx-platform, this constraint needs to be removed (edx-platform is on the latest version of the
cryptographypackage).CircleCI provides custom docker images but to be able to use Docker Hub images, to get around the rate-limiting, tokens will need to be set up (I am not clear why we haven't hit that for the
alpineimage). Instead it is simpler to switch to Github actions which is already being used for two workflows in this repo and which a number of other repos in the edx org have switched to.Ticket
Author Comments, Concerns, and Open Questions
Test Instructions
TODOs
If anything isn't yet done, list it here
cryptographyandmysqlclientpackages.