Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Enable new SQL query engine #989

Merged
merged 8 commits into from
Jan 26, 2021
Merged

Conversation

dai-chen
Copy link
Member

@dai-chen dai-chen commented Jan 14, 2021

PLEASE DO NOT MERGE THIS REQUEST UNTIL READY

Issue #, if available: #1005

Description of changes:

  1. Change new engine setting default value to true
  2. Disable new engine for old IT task in build.gradle and do nothing for new IT task
  3. Remove unnecessary setting change calls in new ITs.

Documentation:

  1. Add new intro doc and update README: https://github.com/opendistro-for-elasticsearch/sql/blob/feature/sql-new-engine-enabled/docs/dev/NewSQLEngine.md
  2. Change user manual to guide how to disable it: https://github.com/opendistro-for-elasticsearch/sql/blob/feature/sql-new-engine-enabled/docs/user/admin/settings.rst#opendistro-sql-engine-new-enabled

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #989 (c43d8af) into develop (43f41bd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #989   +/-   ##
==========================================
  Coverage      99.87%   99.87%           
  Complexity      2406     2406           
==========================================
  Files            234      234           
  Lines           5524     5524           
  Branches         357      357           
==========================================
  Hits            5517     5517           
  Misses             5        5           
  Partials           2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43f41bd...c43d8af. Read the comment docs.

@dai-chen dai-chen self-assigned this Jan 14, 2021
@dai-chen dai-chen added enhancement New feature or request SQL labels Jan 14, 2021
@dai-chen dai-chen marked this pull request as ready for review January 25, 2021 23:04
Copy link
Contributor

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change.

Copy link
Contributor

@harold-wang harold-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for enabling new SQL engine.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request SQL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants