Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Project operator pushdown #933

Merged

Conversation

penghuo
Copy link
Contributor

@penghuo penghuo commented Dec 15, 2020

Issue #, if available: N/A

Description of changes:

  1. Add Project push down in Elasticsearch storage engine layer.
  2. Doc. https://github.com/penghuo/sql/blob/project-pushdown/docs/user/optimization/optimization.rst#push-project-into-query-dsl

*Todo: #934

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@penghuo penghuo added enhancement New feature or request PPL SQL labels Dec 15, 2020
@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #933 (faeb36f) into develop (64c7bd6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             develop     #933    +/-   ##
===========================================
  Coverage      99.86%   99.87%            
- Complexity      2265     2340    +75     
===========================================
  Files            229      232     +3     
  Lines           5235     5389   +154     
  Branches         346      350     +4     
===========================================
+ Hits            5228     5382   +154     
  Misses             5        5            
  Partials           2        2            
Impacted Files Coverage Δ Complexity Δ
...ical/ElasticsearchLogicalPlanOptimizerFactory.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...icsearch/sql/expression/ExpressionNodeVisitor.java 100.00% <100.00%> (ø) 14.00 <1.00> (ø)
...planner/logical/ElasticsearchLogicalIndexScan.java 100.00% <100.00%> (ø) 7.00 <3.00> (+3.00)
...ch/planner/logical/rule/OptimizationRuleUtils.java 100.00% <100.00%> (ø) 9.00 <3.00> (+3.00)
.../planner/logical/rule/PushProjectAndIndexScan.java 100.00% <100.00%> (ø) 7.00 <7.00> (?)
...h/planner/logical/rule/PushProjectAndRelation.java 100.00% <100.00%> (ø) 5.00 <5.00> (?)
.../sql/elasticsearch/storage/ElasticsearchIndex.java 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
.../elasticsearch/storage/ElasticsearchIndexScan.java 100.00% <100.00%> (ø) 19.00 <1.00> (+1.00)
...opendistroforelasticsearch/sql/expression/DSL.java 100.00% <0.00%> (ø) 128.00% <0.00%> (+9.00%)
...elasticsearch/sql/analysis/ExpressionAnalyzer.java 100.00% <0.00%> (ø) 31.00% <0.00%> (+1.00%)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64c7bd6...faeb36f. Read the comment docs.

@penghuo penghuo changed the title Project pushdown Project operator pushdown Dec 15, 2020
@penghuo penghuo marked this pull request as ready for review December 15, 2020 16:16
Copy link
Member

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@penghuo penghuo merged commit c700249 into opendistro-for-elasticsearch:develop Dec 15, 2020
penghuo added a commit to penghuo/sql that referenced this pull request Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request PPL SQL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants