-
Notifications
You must be signed in to change notification settings - Fork 186
Support show and describe statement #907
Support show and describe statement #907
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #907 +/- ##
===========================================
Coverage 99.85% 99.86%
- Complexity 2149 2190 +41
===========================================
Files 216 222 +6
Lines 4851 5028 +177
Branches 323 326 +3
===========================================
+ Hits 4844 5021 +177
Misses 5 5
Partials 2 2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks! Could you check if any change needed to avoid this SHOW/DESCRIBE explain issue in new engine? #404
And could you also check if these 2 can be supported now?
- Extend support for SHOW query to apply filter on TABLE_CAT, TABLE_SCHEM and TABLE_TYPE #324: Filter by TABLE_CAT, TABLE_SCHEM and TABLE_TYPE
- <catalog>.<table> syntax not supported #238: Support for
<catalog>.<table>
|
* add frontend support * update core * add elasticsearch * update * add debug * fix UT * update * add comments * add explain * update
* add frontend support * update core * add elasticsearch * update * add debug * fix UT * update * add comments * add explain * update
Related Issue:
#404
Description of changes
SELECT * FROM TABEL
the * should be expanded following the order defined by TABLE schema.Breaking Change
In the legacy engine, if the index has alias, the index name will be returned instead of the alias name. e.g.
The demo_index will be returned as table name instead of demo_alias. In the new engine, we change to retrun the alias name, in the example, the demo_alias will be returned.
Todo
The current implementation doesn't existly follow the semantic definition of LIKE operator. Ideally, the operand of LIKE operator shoud be string literal to represent the match pattern. But the legacy engine use identifier in this case, e.g.
SHOW TABLES LIKE %
. For backward compability reason, we still support it now, but it will be deprecated soon.To Reviewer
I briefly describe the changed files in each module.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.