This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 186
Support NULLS FIRST/LAST in new engine #843
Merged
dai-chen
merged 18 commits into
opendistro-for-elasticsearch:develop
from
dai-chen:support-order-by-null-order-2
Nov 23, 2020
Merged
Support NULLS FIRST/LAST in new engine #843
dai-chen
merged 18 commits into
opendistro-for-elasticsearch:develop
from
dai-chen:support-order-by-null-order-2
Nov 23, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #843 +/- ##
==========================================
Coverage 99.84% 99.85%
- Complexity 2094 2102 +8
==========================================
Files 209 209
Lines 4658 4678 +20
Branches 301 308 +7
==========================================
+ Hits 4651 4671 +20
Misses 5 5
Partials 2 2
Continue to review full report at Codecov.
|
penghuo
approved these changes
Nov 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change.
chloe-zh
approved these changes
Nov 23, 2020
penghuo
pushed a commit
that referenced
this pull request
Dec 15, 2020
* Change grammar * Add ast building and UT * Pass jacoco * Handle nullfirst option in analyzer * Add comparison test * Fix broken UT * Add comparison test with null * Add more comparison test * Add doctest * Update readme with features only avaiable in new engine for clarity * Prepare PR * Update doc * Update doc * Update doc * Update doc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
NULLS FIRST
andNULLS LAST
clause.NULLS
clause absent.TODO: Add support in window function
OVER
clause. Because AST window function is unresolved expression instead of operator, regularORDER BY
and that in over clause cannot share same logic.Documentation:
Testing:
can_build_from_subquery()
because new SQL doesn't support keyword as alias name.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.