This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Support CASE clause in new engine #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penghuo
reviewed
Nov 13, 2020
core/src/main/java/com/amazon/opendistroforelasticsearch/sql/analysis/ExpressionAnalyzer.java
Show resolved
Hide resolved
chloe-zh
approved these changes
Nov 13, 2020
penghuo
pushed a commit
that referenced
this pull request
Dec 15, 2020
* Change grammar and UT * Add case expression * Pass jacoco in sql module * Pass jacoco in core module and refactor when clause * Fix broken IT and add javadoc * Add comparison test for basic case * Add comparison test for complex case * Add doctest * Add type check * Prepare PR * Prepare PR * Address PR comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes: Add support for
CASEclause in new SQL engine.CASEandWHENclause.TODO: Case function for PPL is not done yet. Reference: https://docs.splunk.com/Documentation/Splunk/8.1.0/SearchReference/ConditionalFunctions
Documentation: https://github.com/dai-chen/sql/blob/support-case-statement-in-new-engine/docs/user/dql/functions.rst#case
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.