This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
changes required for using to Power BI Service with Open Distro For Elasticsearch #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
July 18, 2020 21:01
- add docs
- add unit test - add errors - enable direct query
…e/odbc/pbi # Conflicts: # sql-odbc/.gitignore # sql-odbc/src/PowerBIConnector/OdfeSqlOdbcPBIConnector.mproj # sql-odbc/src/PowerBIConnector/OdfeSqlOdbcPBIConnector.pq # sql-odbc/src/PowerBIConnector/OdfeSqlOdbcPBIConnector.query.pq # sql-odbc/src/PowerBIConnector/bin/Release/OdfeSqlOdbcPBIConnector.mez
added 17 commits
July 29, 2020 15:57
…e/odbc/pbi # Resolved Conflicts: # sql-odbc/src/PowerBIConnector/OdfeSqlOdbcPBIConnector.pq # sql-odbc/src/PowerBIConnector/bin/Release/OdfeSqlOdbcPBIConnector.mez
- update user docs
…e/odbc/pbi # Conflicts: # sql-odbc/src/PowerBIConnector/bin/Release/OdfeSqlOdbcPBIConnector.mez
jordanw-bq
reviewed
Aug 7, 2020
| ConnectionString = [ | ||
| Driver = "ODFE SQL ODBC Driver" | ||
| Driver = "ODFE SQL ODBC Driver", | ||
| Host = Server |
There was a problem hiding this comment.
Do we need to do anything on the driver side to handle this change?
(ie. will the driver understand a Host value of localhost:9200?)
There was a problem hiding this comment.
The driver doesn't need any change. I tested with PBI and ODBC administrator.
jordanw-bq
approved these changes
Aug 7, 2020
chloe-zh
approved these changes
Aug 7, 2020
dai-chen
approved these changes
Aug 7, 2020
added 2 commits
August 9, 2020 21:58
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #668
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.