This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 186
ODBC: improve Windows build process #661
Merged
dai-chen
merged 17 commits into
opendistro-for-elasticsearch:develop
from
jordanw-bq:odbc-improve-win-build-scripts
Aug 18, 2020
Merged
ODBC: improve Windows build process #661
dai-chen
merged 17 commits into
opendistro-for-elasticsearch:develop
from
jordanw-bq:odbc-improve-win-build-scripts
Aug 18, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- combine build code into one script for easier edits - introduced UNITY build for AWS SDK
rupal-bq
reviewed
Aug 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should sql-odbc-release-workflow.yml
have the same build updates as sql-odbc-main.yml
?
rupal-bq
reviewed
Aug 11, 2020
sql-odbc/docs/dev/run_tests.md
Outdated
4. Select 'Add data' under 'Sample eCommerce orders' | ||
5. Select 'Add data' under 'Sample web logs' | ||
|
||
Then load custom data sets using the kibana console. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a reference to required custom dataset kibana_sample_data_types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added reference
rupal-bq
approved these changes
Aug 18, 2020
chloe-zh
approved these changes
Aug 18, 2020
dai-chen
approved these changes
Aug 18, 2020
dai-chen
pushed a commit
that referenced
this pull request
Apr 30, 2021
* improve Windows build process - combine build code into one script for easier edits - introduced UNITY build for AWS SDK * update CI scripts * workflow updates * more workflow updates * workflow updates * workflow updates * update WinArch for VLD dll * print build_installer args * use Windows path separator & print CI output args for debugging * use Powershell envar syntax * workflow & ci script updates * update cmake path for 32-bit install * fix uplaod step path names * adding Env prefix for artifact steps * hardcode upload step paths * add link to custom test dataset * copy build script upgrades to release workflow
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #659
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.