Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

ODBC: improve Windows build process #661

Conversation

jordanw-bq
Copy link
Contributor

Issue #, if available: #659

Description of changes:

  • combine build code into one script for easier edits
  • introduced UNITY build for AWS SDK

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@rupal-bq rupal-bq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should sql-odbc-release-workflow.yml have the same build updates as sql-odbc-main.yml ?

4. Select 'Add data' under 'Sample eCommerce orders'
5. Select 'Add data' under 'Sample web logs'

Then load custom data sets using the kibana console.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a reference to required custom dataset kibana_sample_data_types

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added reference

@dai-chen dai-chen merged commit 0f7c261 into opendistro-for-elasticsearch:develop Aug 18, 2020
dai-chen pushed a commit that referenced this pull request Apr 30, 2021
* improve Windows build process

- combine build code into one script for easier edits
- introduced UNITY build for AWS SDK

* update CI scripts

* workflow updates

* more workflow updates

* workflow updates

* workflow updates

* update WinArch for VLD dll

* print build_installer args

* use Windows path separator & print CI output args for debugging

* use Powershell envar syntax

* workflow & ci script updates

* update cmake path for 32-bit install

* fix uplaod step path names

* adding Env prefix for artifact steps

* hardcode upload step paths

* add link to custom test dataset

* copy build script upgrades to release workflow
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants