This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 186
Support mathematical functions rand and constants e, pi #591
Merged
chloe-zh
merged 6 commits into
opendistro-for-elasticsearch:develop
from
chloe-zh:math3
Jul 22, 2020
Merged
Support mathematical functions rand and constants e, pi #591
chloe-zh
merged 6 commits into
opendistro-for-elasticsearch:develop
from
chloe-zh:math3
Jul 22, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # core/src/main/java/com/amazon/opendistroforelasticsearch/sql/expression/DSL.java # core/src/main/java/com/amazon/opendistroforelasticsearch/sql/expression/function/BuiltinFunctionName.java # core/src/main/java/com/amazon/opendistroforelasticsearch/sql/expression/operator/arthmetic/MathematicalFunction.java # core/src/test/java/com/amazon/opendistroforelasticsearch/sql/expression/operator/arthmetic/MathematicalFunctionTest.java # integ-test/src/test/java/com/amazon/opendistroforelasticsearch/sql/ppl/MathematicalFunctionIT.java # integ-test/src/test/resources/correctness/expressions/functions.txt # ppl/src/main/antlr/OpenDistroPPLLexer.g4 # ppl/src/main/antlr/OpenDistroPPLParser.g4 # sql/src/main/antlr/OpenDistroSQLParser.g4
dai-chen
reviewed
Jul 20, 2020
dai-chen
reviewed
Jul 21, 2020
dai-chen
approved these changes
Jul 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
penghuo
approved these changes
Jul 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
RAND
Usage:
rand()
/rand(N)
returns a random floating-point value in the range 0 <= value < 1.0. If integer N is specified, the seed is initialized prior to execution. One implication of this behavior is with identical argument N,rand(N)
returns the same value each time, and thus produces a repeatable sequence of column values.Argument type: x: STRING, a: INTEGER, b: INTEGER
Return type: STRING
E
Usage:
e()
returns the Euler's numberReturn type: DOUBLE
PI
Usage:
pi()
returns the constant piReturn type: DOUBLE
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.