Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

add date and time support #568

Merged
merged 4 commits into from
Jul 13, 2020

Conversation

penghuo
Copy link
Contributor

@penghuo penghuo commented Jul 13, 2020

Description of changes

  1. Define DATE, TIME, TIMESTAMP as the core type of query engine.
  2. Add the date, time and timestamp Literal.
  3. Add the INTEGER dayofmonth(DATE) function.
  4. Add the doc. https://github.com/penghuo/sql/blob/datetype/docs/user/dql/expressions.rst

To Reviewer

  1. Missing the correct test, because the JDBC doesn't support TIMESTAMP and TIME type, and also has the wrong mapping between DATE and TIMESTMAP.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@penghuo penghuo self-assigned this Jul 13, 2020
Copy link
Member

@chloe-zh chloe-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the changes!

@penghuo penghuo merged commit bc02233 into opendistro-for-elasticsearch:develop Jul 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants